This repository has been archived by the owner on Jul 4, 2022. It is now read-only.
refactor Plug to use the new versioned Doughnut enum type #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aliXsed
reviewed
Dec 22, 2019
aliXsed
reviewed
Dec 22, 2019
aliXsed
reviewed
Dec 22, 2019
aliXsed
reviewed
Dec 22, 2019
aliXsed
reviewed
Dec 22, 2019
aliXsed
reviewed
Dec 22, 2019
aliXsed
reviewed
Dec 22, 2019
aliXsed
reviewed
Dec 22, 2019
aliXsed
reviewed
Dec 22, 2019
aliXsed
reviewed
Dec 22, 2019
aliXsed
reviewed
Dec 22, 2019
aliXsed
reviewed
Dec 23, 2019
| @@ -12,7 +12,7 @@ use rstd::prelude::*; | |||
| use primitives::OpaqueMetadata; | |||
| use sp_runtime::{ | |||
| ApplyExtrinsicResult, transaction_validity::TransactionValidity, generic, create_runtime_str, | |||
| impl_opaque_keys, MultiSignature, DoughnutV0 | |||
| impl_opaque_keys, MultiSignature, Doughnut | |||
There was a problem hiding this comment.
I guess you can remove Doughnut from this line
| @@ -258,6 +262,8 @@ mod tests { | |||
| domains: vec![("test".to_string(), vec![0u8])], | |||
| }; | |||
| doughnut.signature = issuer.sign(&doughnut.payload()).into(); | |||
There was a problem hiding this comment.
doughnut_v0.signature = issuer.sign(&doughnut_v0.payload()).into();
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doughnut-rsand bump new version0.3.0Updated the original issue, need more time to solve this one
Closes #37