Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use database transactions for the bulk generation #157

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

boazpoolman
Copy link
Member

@boazpoolman boazpoolman commented Aug 13, 2024

What does it do?

Handle bulk generation using database transactions.

Why is it needed?

Because bulk generating the URL aliases could potentially be a very large task. Using database transactions we can assure the database is not in a "half" broken state mid bulk generation.

How to test it?

Test the different features of the bulk generation feature.

Related issue(s)/PR(s)

#13

Todo

Copy link

changeset-bot bot commented Aug 13, 2024

🦋 Changeset detected

Latest commit: 2b1f411

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@pluginpal/webtools-core Minor
@pluginpal/webtools-addon-menus Major
@pluginpal/webtools-addon-redirects Major
@pluginpal/webtools-addon-sitemap Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov-commenter
Copy link

codecov-commenter commented Aug 13, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 30.21%. Comparing base (16af956) to head (2b1f411).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #157      +/-   ##
==========================================
- Coverage   30.21%   30.21%   -0.01%     
==========================================
  Files           4        4              
  Lines       13968    13975       +7     
  Branches     4974     4975       +1     
==========================================
+ Hits         4221     4223       +2     
- Misses       7709     7714       +5     
  Partials     2038     2038              
Flag Coverage Δ
unit 30.21% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants