-
-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/60 use same collection with different patterns #161
Feature/60 use same collection with different patterns #161
Conversation
|
packages/core/server/admin-api/services/query-layer-decorator.ts
Outdated
Show resolved
Hide resolved
7ceb732
to
6b1e563
Compare
fa7f63b
to
6623c50
Compare
6623c50
to
3d9404c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @TMSchipper
This looks really good, nice work.
I've left a couple comments regarding code style and some potentially unhandled bugs.
I also think you need to address the following things before we can get this merged:
- The host entity will still have a relation to only a single url_alias. We should probably update that to be a oneToMany relation instead of oneToOne. So then the entity will actually have a relation to all it's URL aliases.
- When we've established the oneToMany relation we need to have a way to define what is the primary URL alias of an entity. This is the URL alias which will be used when we're linking from one page to another. We need to have a single URL alias to make that link.
- We need to have a way for the Strapi Editor manage the multiple URL aliases. This needs to be developed in the admin panel. That way we can see the different URL aliases and manage them from within the edit form of a page.
- We probably need to update/add some unit tests for this new feature.
…ent-patterns # Conflicts: # packages/core/server/admin-api/services/bulk-generate.ts # packages/core/server/admin-api/services/url-pattern.ts
a444a18
to
e8a273f
Compare
8c3f2c5
to
c2e3559
Compare
270441f
to
c01fcb1
Compare
c01fcb1
to
e9f53c4
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #161 +/- ##
==========================================
- Coverage 38.14% 37.96% -0.18%
==========================================
Files 4 4
Lines 839 864 +25
Branches 181 189 +8
==========================================
+ Hits 320 328 +8
- Misses 419 432 +13
- Partials 100 104 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…ature/60-use-same-collection-with-different-patterns
What does it do?
Describe the technical changes you did.
Why is it needed?
Describe the issue you are solving.
How to test it?
Provide information about the environment and the path to verify the behaviour.
Related issue(s)/PR(s)
Let us know if this is related to any issue/pull request