Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sitemap generation issue when the i18n plugin is not installed #189

Merged
merged 1 commit into from
Sep 1, 2024

Conversation

boazpoolman
Copy link
Member

No description provided.

@boazpoolman boazpoolman requested a review from TMSchipper August 28, 2024 19:38
Copy link

changeset-bot bot commented Aug 28, 2024

🦋 Changeset detected

Latest commit: 52417df

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@pluginpal/webtools-addon-sitemap Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 38.24%. Comparing base (da0f486) to head (52417df).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #189      +/-   ##
==========================================
- Coverage   38.35%   38.24%   -0.11%     
==========================================
  Files           4        4              
  Lines         837      834       -3     
  Branches      174      178       +4     
==========================================
- Hits          321      319       -2     
+ Misses        479      475       -4     
- Partials       37       40       +3     
Flag Coverage Δ
unit 38.24% <ø> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@boazpoolman boazpoolman merged commit de693c7 into master Sep 1, 2024
4 of 5 checks passed
@boazpoolman boazpoolman deleted the feature/fix-sitemap-issue branch September 1, 2024 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants