Merge pull request #84 from garethjevans/review

feat: show review status on 'get prs'
plumming · Dec 8, 2020 · 4639136 · 4639136
2 parents a0a1f4c + a3b0ff4
commit 4639136
Show file tree

Hide file tree

Showing 4 changed files with 30 additions and 10 deletions.
diff --git a/pkg/cmd/common_cmd_test.go b/pkg/cmd/common_cmd_test.go
@@ -36,6 +36,7 @@ func TestCommonCmd_Filter_AllData(t *testing.T) {
     "repository": {
       "nameWithOwner": ""
     },
+    "reviewDecision": "",
     "title": "",
     "url": ""
   },
@@ -56,6 +57,7 @@ func TestCommonCmd_Filter_AllData(t *testing.T) {
     "repository": {
       "nameWithOwner": ""
     },
+    "reviewDecision": "",
     "title": "",
     "url": ""
   },
@@ -76,6 +78,7 @@ func TestCommonCmd_Filter_AllData(t *testing.T) {
     "repository": {
       "nameWithOwner": ""
     },
+    "reviewDecision": "",
     "title": "",
     "url": ""
   }
@@ -111,6 +114,7 @@ func TestCommonCmd_Filter_FilterOnAuthor(t *testing.T) {
     "repository": {
       "nameWithOwner": ""
     },
+    "reviewDecision": "",
     "title": "",
     "url": ""
   }

diff --git a/pkg/cmd/getcmd/get_prs.go b/pkg/cmd/getcmd/get_prs.go
@@ -97,6 +97,7 @@ func (c *GetPrsCmd) Run() error {
 				"Author",
 				"Title",
 				"Age",
+				"Review",
 				"Labels",
 				"Mergeable",
 			)
@@ -111,6 +112,7 @@ func (c *GetPrsCmd) Run() error {
 				pr.Author.Login,
 				pr.ColoredTitle(),
 				util.SafeTime(&pr.CreatedAt),
+				pr.ColoredReviewDecision(),
 				pr.LabelsString(),
 				pr.MergeableString(),
 			)

diff --git a/pkg/domain/get_prs.go b/pkg/domain/get_prs.go
@@ -69,6 +69,7 @@ func (g *GetPrs) Run() error {
             name
           }
         }
+        reviewDecision
         commits(last: 1){
           nodes{
             commit{

diff --git a/pkg/pr/pr.go b/pkg/pr/pr.go
@@ -10,16 +10,17 @@ import (
 )
 
 type PullRequest struct {
-	Number     int        `json:"number"`
-	Title      string     `json:"title"`
-	URL        string     `json:"url"`
-	Mergeable  string     `json:"mergeable"`
-	CreatedAt  time.Time  `json:"createdAt"`
-	Author     Author     `json:"author"`
-	Labels     Labels     `json:"labels"`
-	Commits    Commits    `json:"commits"`
-	Closed     bool       `json:"closed"`
-	Repository Repository `json:"repository"`
+	Number         int        `json:"number"`
+	Title          string     `json:"title"`
+	URL            string     `json:"url"`
+	Mergeable      string     `json:"mergeable"`
+	CreatedAt      time.Time  `json:"createdAt"`
+	Author         Author     `json:"author"`
+	Labels         Labels     `json:"labels"`
+	Commits        Commits    `json:"commits"`
+	Closed         bool       `json:"closed"`
+	Repository     Repository `json:"repository"`
+	ReviewDecision string     `json:"reviewDecision"`
 }
 
 const (
@@ -112,6 +113,18 @@ func (p *PullRequest) ColoredTitle() string {
 	}
 }
 
+func (p *PullRequest) ColoredReviewDecision() string {
+	if p.ReviewDecision == "APPROVED" {
+		return util.ColorInfo("Approved")
+	} else if p.ReviewDecision == "REVIEW_REQUIRED" {
+		return util.ColorWarning("Required")
+	} else if p.ReviewDecision == "CHANGES_REQUESTED" {
+		return util.ColorError("Changes Requested")
+	} else {
+		return p.ReviewDecision
+	}
+}
+
 func (p *PullRequest) TrimmedTitle() string {
 	if len(p.Title) > 75 {
 		return fmt.Sprintf("%s...", p.Title[:75])
-Original file line number
+Diff line change
@@ Expand Up / @@ -69,6 +69,7 @@ func (g *GetPrs) Run() error { @@
                 name
               }
             }
+            reviewDecision
             commits(last: 1){
               nodes{
                 commit{
@@ Expand Down @@