-
Notifications
You must be signed in to change notification settings - Fork 2
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Rework validation of names and aliases for aggregate UDFs
Add better validation that `name = ...` and `alias = ...` line up when there is a mismatch between the `BasicUdf` and `AggregateUdf` implementation, and fix a problem that was disallowing use of aliases in aggregate UDFs. Error messages are significantly improved. Fixes <#59>
- Loading branch information
Showing
17 changed files
with
1,302 additions
and
117 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -24,12 +24,20 @@ jobs: | |
runs-on: ubuntu-latest | ||
steps: | ||
- uses: actions/checkout@v2 | ||
- uses: dtolnay/[email protected] | ||
with: | ||
components: clippy | ||
- run: rustup default 1.72.0 && rustup component add clippy && rustup update | ||
- uses: Swatinem/rust-cache@v2 | ||
- run: cargo clippy --all-features --all-targets | ||
- run: cargo clippy --no-default-features --all-targets | ||
|
||
clippy: | ||
name: "MSRV" | ||
runs-on: ubuntu-latest | ||
steps: | ||
- uses: actions/checkout@v2 | ||
- run: rustup default 1.65.0 && rustup update | ||
- uses: Swatinem/rust-cache@v2 | ||
- run: cargo clippy --all-features --all-targets -- -D warnings | ||
- run: cargo clippy --no-default-features --all-targets -- -D warnings | ||
- run: cargo check --all-features --all-targets | ||
- run: cargo check --no-default-features --all-targets | ||
|
||
test: | ||
strategy: | ||
|
@@ -53,19 +61,18 @@ jobs: | |
MYSQLCLIENT_LIB_DIR: C:\mysql\lib | ||
steps: | ||
- uses: actions/checkout@v2 | ||
- name: List files | ||
run: | | ||
pwd | ||
ls | ||
# use a version later than MSRV for trybuild consistency | ||
- run: rustup default 1.77 && rustup update | ||
- uses: Swatinem/rust-cache@v2 | ||
- uses: dtolnay/[email protected] | ||
- run: cargo test | ||
|
||
integration: | ||
name: "Integration testing (docker)" | ||
runs-on: ubuntu-latest | ||
steps: | ||
- uses: actions/checkout@v2 | ||
- run: rustup default stable && rustup update | ||
- uses: Swatinem/rust-cache@v2 | ||
- name: Cache Docker layers | ||
uses: actions/cache@v2 | ||
id: cache-docker | ||
|
@@ -104,7 +111,6 @@ jobs: | |
-e RUST_LIB_BACKTRACE=1 | ||
--name mdb-example-container | ||
mdb-example-so | ||
- uses: dtolnay/rust-toolchain@stable | ||
- name: Run integration testing | ||
# Run only integration tests with `--test '*'` | ||
run: cargo test -p udf-examples --test '*' --features backend | ||
|
@@ -121,9 +127,7 @@ jobs: | |
runs-on: ubuntu-latest | ||
steps: | ||
- uses: actions/checkout@v2 | ||
- uses: dtolnay/rust-toolchain@nightly | ||
with: | ||
components: miri | ||
- run: rustup default nightly && rustup component add miri && rustup update | ||
- uses: Swatinem/rust-cache@v2 | ||
- name: Run Miri | ||
env: | ||
|
@@ -136,9 +140,7 @@ jobs: | |
runs-on: ubuntu-latest | ||
steps: | ||
- uses: actions/checkout@v2 | ||
- uses: dtolnay/rust-toolchain@nightly | ||
with: | ||
components: rustfmt | ||
- run: rustup default nightly && rustup component add rustfmt && rustup update | ||
- uses: Swatinem/rust-cache@v2 | ||
- run: cargo fmt --all -- --check | ||
- uses: actions/setup-python@v3 | ||
|
@@ -151,7 +153,7 @@ jobs: | |
runs-on: ubuntu-latest | ||
steps: | ||
- uses: actions/checkout@v2 | ||
- uses: dtolnay/rust-toolchain@nightly | ||
- run: rustup default nightly && rustup update | ||
- uses: Swatinem/rust-cache@v2 | ||
- run: cargo doc | ||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,3 @@ | ||
**/target | ||
**/Cargo.lock | ||
**/.DS_Store | ||
.docker-cargo/ |
Oops, something went wrong.