-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added AIR for live reloading go when changes are made #36
Conversation
@unamdev0 is attempting to deploy a commit to the formulosity Team on Vercel. A member of the Team first needs to authorize it. |
README.md
Outdated
Run the following command for setting up backend for development purpose | ||
|
||
``` | ||
make run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we add cd api here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure,would add once the below conversations are resolved
README.md
Outdated
make run | ||
``` | ||
|
||
Or if air is locally installed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make air a link to the project
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will do
api/Makefile
Outdated
@@ -1,3 +1,12 @@ | |||
AIR_BIN=bin/air |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wait, should it be installed inside the repo? not globally?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@plutov , I just wanted to give option to developers in case they do not know about air or it's setup, they can directly run formulosity without having to worry about setting up AIR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If they don't know about air then they probably don't need it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
haha, makes sense, will make the changes and let you know
api/Makefile
Outdated
run: | ||
if [ ! -f $(AIR_BIN) ]; then \ | ||
echo "Installing Air locally..."; \ | ||
go build -o $(AIR_BIN) github.com/air-verse/air; \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think air should be globally installed not inside the repo.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes @plutov, I agree, but in case if it's not installed globally, formulosity can still be ran in dev mode if we install it locally in this project itself.
But, I'd prefer for global installation, what do you suggest? Should we make it compulsory for AIR to be installed gloabally?
@plutov changes have been made,can you check once |
No description provided.