-
Notifications
You must be signed in to change notification settings - Fork 0
[Feat] 유효성 검사 기능 추가 #11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- 기존 방식 : BaseErrorCode 클래스를 멤버로 사용하여 각 enum 상수마다 별도의 BaseErrorCode 인스턴스가 생성됨 - 단순한 에러 코드 정보만 필요하다는 점을 고려하여 enum이 ErrorCode를 직접 구현하는 방식으로 변경
+ ValidationError에 rejectedValue 제공
많은 곳에서 해당 필드를 검정하고 있기 때문에, 어노테이션을 구현함
`ValidationError` 클래스에서 `rejectedValue` 필드 제거 민감한 정보를 포함할 가능성이 있으며, 아닌 경우에도 굳이 제공할 필요가 없다고 판단하여 삭제
- `@ValidPassword` 커스텀 어노테이션 구현 - `PasswordValidator` 구현 - 기존 DTO들의 password 필드에 해당 어노테이션 적용
Contributor
|
고생하셨습니다!! 하단의 코멘트 참고부탁드립니다ㅎㅎ
|
Contributor
Author
|
도메인이름 + 일련번호 적용
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🛰️ Issue Number
🪐 작업 내용
기존 방식 : BaseErrorCode 클래스를 멤버로 사용하여 각 enum 상수마다 별도의 BaseErrorCode 인스턴스가 생성됨
✅ Check List