fix an issue with recursive types, fixes #890

.changeset/little-wolves-play.md

@@ -0,0 +1,5 @@
+---
+"counterfact": patch
+---
+
+fix invalid TypeScript generated for recursive types

openapi-example.yaml

@@ -67,7 +67,7 @@ paths:
           content:
             application/json:
               schema:
-                type: string
+                $ref: "#/components/schemas/Recursive"
         "400":
           $ref: "#/components/responses/BadRequest"
 
@@ -94,6 +94,9 @@ components:
           description: A detailed description of the error
       required:
         - message
+    Recursive:
+      oneOf:
+        - { $ref: "#/components/schemas/Recursive" }
 
   securitySchemes:
     basicAuth:

src/typescript-generator/script.js

@@ -27,7 +27,7 @@ export class Script {
 
   firstUniqueName(coder) {
     for (const name of coder.names()) {
-      if (!this.imports.has(name) && !this.exports.has(name)) {
+      if (!this.imports.has(name)) {
         return name;
       }
     }

test/typescript-generator/script.test.js

@@ -172,35 +172,36 @@ describe("a Script", () => {
   it("creates export statements", async () => {
     const repository = new Repository("/base/path");
 
-    class CoderThatWantsToImportAccount extends Coder {
+    class AccountCoder extends Coder {
       *names() {
-        let index = 0;
-
-        while (true) {
-          yield `Account${index}`;
-          index += 1;
-        }
+        yield "Account";
       }
 
       write() {
         return "{ }";
       }
     }
 
-    const coder = new CoderThatWantsToImportAccount({});
+    class AccountTypeCoder extends Coder {
+      *names() {
+        yield "AccountType";
+      }
+
+      write() {
+        return "{ }";
+      }
+    }
 
     const script = repository.get("export-to-me.ts");
 
-    script.export(coder);
-    script.exportType(coder);
-    script.exportDefault(coder);
+    script.export(new AccountCoder({}));
+    script.exportType(new AccountTypeCoder({}));
 
     await script.finished();
 
     expect(script.exportStatements()).toStrictEqual([
-      "export const Account0 = { };",
-      "export type Account1 = { };",
-      "export default { };",
+      "export const Account = { };",
+      "export type AccountType = { };",
     ]);
   });