Merge pull request #1084 from pmcelhaney/disable-fill-properties-json…

…-schema feat(server): Update JSONSchemaFaker not to create fake object properties
pmcelhaney · Oct 17, 2024 · d60c90d · d60c90d
2 parents 178f4e7 + 707a0ec
commit d60c90d
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 0 deletions.
diff --git a/.changeset/selfish-numbers-matter.md b/.changeset/selfish-numbers-matter.md
@@ -0,0 +1,5 @@
+---
+"counterfact": patch
+---
+
+Updates JSONSchemaFaker to have the fillProperties option false so it will not make up fake object properties
diff --git a/src/server/response-builder.ts b/src/server/response-builder.ts
@@ -8,6 +8,7 @@ JSONSchemaFaker.option("minItems", 0);
 JSONSchemaFaker.option("maxItems", 20);
 JSONSchemaFaker.option("failOnInvalidTypes", false);
 JSONSchemaFaker.option("failOnInvalidFormat", false);
+JSONSchemaFaker.option("fillProperties", false);
 
 function convertToXmlIfNecessary(
   type: string,

diff --git a/src/server/tools.ts b/src/server/tools.ts
@@ -1,6 +1,7 @@
 import { JSONSchemaFaker, type Schema } from "json-schema-faker";
 
 JSONSchemaFaker.option("useExamplesValue", true);
+JSONSchemaFaker.option("fillProperties", false);
 
 export class Tools {
   private readonly headers: { [key: string]: string[] | string | undefined };