print appropriate status message when the proxy URL is not set

pmcelhaney · May 22, 2024 · faed043 · faed043
1 parent 42f6336
commit faed043
Show file tree

Hide file tree

Showing 3 changed files with 24 additions and 1 deletion.
diff --git a/bin/counterfact.js b/bin/counterfact.js
@@ -152,7 +152,7 @@ async function main(source, destination) {
     openApiPath: source,
     port: options.port,
     proxyPaths: new Map([["", Boolean(options.proxyUrl)]]),
-    proxyUrl: options.proxyUrl,
+    proxyUrl: options.proxyUrl ?? "",
     routePrefix: options.prefix,
     startRepl: options.repl,
     startServer: options.serve,

diff --git a/src/repl/repl.ts b/src/repl/repl.ts
@@ -12,7 +12,14 @@ export function startRepl(
   config: Config,
   print = printToStdout,
 ) {
+  // eslint-disable-next-line max-statements
   function printProxyStatus() {
+    if (config.proxyUrl === "") {
+      print("The proxy URL is not set.");
+      print('To set it, type ".proxy url <url>');
+      return;
+    }
+
     print("Proxy Configuration:");
     print("");
     print(`The proxy URL is ${config.proxyUrl}`);

diff --git a/test/repl/repl.test.ts b/test/repl/repl.test.ts
@@ -151,6 +151,22 @@ describe("REPL", () => {
     expect(harness.isReset()).toBe(true);
   });
 
+  it("shows the proxy status when no URL is set", () => {
+    const { config, harness } = createHarness();
+
+    config.proxyUrl = "";
+    config.proxyPaths.set("/foo", true);
+    config.proxyPaths.set("/foo/bar", false);
+
+    harness.call("proxy", "status");
+
+    expect(harness.output).toEqual([
+      "The proxy URL is not set.",
+      'To set it, type ".proxy url <url>',
+    ]);
+    expect(harness.isReset()).toBe(true);
+  });
+
   it("displays an explanatory message after turning the proxy on for an endpoint", () => {
     const { harness } = createHarness();
     harness.call("proxy", "on /foo/bar");