Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

untangle type mess #629

Merged
merged 9 commits into from
Nov 17, 2023
Merged

untangle type mess #629

merged 9 commits into from
Nov 17, 2023

Conversation

pmcelhaney
Copy link
Owner

@pmcelhaney pmcelhaney commented Oct 24, 2023

  • put types shared by server and application code in types.d.ts
  • Don't import the Schema type from json-schema-faker because it's no more useful than unknown
  • Fix an issue where HttpStatusCode is not imported in path-types files

@changeset-bot
Copy link

changeset-bot bot commented Oct 24, 2023

⚠️ No Changeset found

Latest commit: 8a6ebb9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coveralls
Copy link
Collaborator

coveralls commented Oct 24, 2023

Pull Request Test Coverage Report for Build 6908039718

  • 17 of 23 (73.91%) changed or added relevant lines in 5 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.1%) to 82.634%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/typescript-generator/repository.js 0 6 0.0%
Files with Coverage Reduction New Missed Lines %
src/typescript-generator/repository.js 1 59.48%
Totals Coverage Status
Change from base Build 6907709769: 0.1%
Covered Lines: 2334
Relevant Lines: 2894

💛 - Coveralls

@pmcelhaney pmcelhaney enabled auto-merge November 17, 2023 17:35
@pmcelhaney pmcelhaney merged commit 58cef6a into main Nov 17, 2023
6 checks passed
@pmcelhaney pmcelhaney deleted the untangle-type-mess branch November 17, 2023 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants