fix(server): Update context find logic in context-registry #943
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 2ff9fdf The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Great find and fix! Can you add a unit test? |
Done. |
Pull Request Test Coverage Report for Build 9502407377Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an OpenApi spec has multiple paths that share the same root, but different child paths, if those parent paths are a mixture of cases, the context registry stores the contexts for the paths once (which is correct), but the
.findoperation incontext-registryexpects the map key to match the path.For example, suppose a spec has paths of
myPets/vaccinationsas well asmypets/visits. Now suppose the user has created a_.context.tsfile atroutes/myPets/_.context.ts. When a request comes in formyPets/vaccinationsit will find the custom context, but when the request comes in formypets/visitsit will fail to find the custom context because it will look for a parent path ofmypetsand nothing exists in the ContextRegistry.entries for that key.This PR fixes the path find logic.