Consolidate upload (#432) #433
Conversation
* feat: merge uploadConfig into CommonConfig * chore: tests successful changes compiled * feat: respect parentProject in upload request When the upload request contains correct parent project information separate requests 1. to check if the parent exists 2. to move the uploaded project in the tree could be skipped. The big advantage is, that admin could separate permissions of teams using the new feature "Portfolio Access Control". Additionally if the uploaded project already exists in any other version the user account does not need the permission PORTFOLIO_MANAGEMENT. * chore: housekeeping * chore: fixed README.md * chore: fixed SonarQube findings * chore: fixed SonarQube findings * fix: added parentUuid to put request * fix: updated README.md * fix: replaced UUID type with String * fix: README.md * chore: Removed unused import 'java.util.UUID'. * Update src/main/java/io/github/pmckeown/dependencytrack/CommonConfig.java Co-authored-by: Paul McKeown <[email protected]> * chore: implemented review comments --------- Co-authored-by: Thomas Hucke <[email protected]> Co-authored-by: Paul McKeown <[email protected]>
|
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
src/main/java/io/github/pmckeown/dependencytrack/upload/UploadBomMojo.java
Outdated
Show resolved
Hide resolved
chore: updated maven dependencies
|
@pmckeown - Would you please check if I could be provided with the permission to directly push my changes? |
I’ve added you as a collaborator so should be good to push. Please check. |
|
|
@pmckeown - got it to push. |
feat: merge uploadConfig into CommonConfig
chore: tests successful changes compiled
feat: respect parentProject in upload request
When the upload request contains correct parent project information separate requests
could be skipped.
The big advantage is, that admin could separate permissions of teams using the new feature "Portfolio Access Control".
Additionally if the uploaded project already exists in any other version the user account does not need the permission PORTFOLIO_MANAGEMENT.
chore: housekeeping
chore: fixed README.md
chore: fixed SonarQube findings
chore: fixed SonarQube findings
fix: added parentUuid to put request
fix: updated README.md
fix: replaced UUID type with String
fix: README.md
chore: Removed unused import 'java.util.UUID'.
Update src/main/java/io/github/pmckeown/dependencytrack/CommonConfig.java
chore: implemented review comments