Skip to content

Consolidate upload (#432)#433

Merged
pmckeown merged 3 commits intomainfrom
feature/consolidate-upload
Dec 14, 2024
Merged

Consolidate upload (#432)#433
pmckeown merged 3 commits intomainfrom
feature/consolidate-upload

Conversation

@pmckeown
Copy link
Copy Markdown
Owner

@pmckeown pmckeown commented Dec 8, 2024

  • feat: merge uploadConfig into CommonConfig

  • chore: tests successful changes compiled

  • feat: respect parentProject in upload request

When the upload request contains correct parent project information separate requests

  1. to check if the parent exists
  2. to move the uploaded project in the tree

could be skipped.
The big advantage is, that admin could separate permissions of teams using the new feature "Portfolio Access Control".

Additionally if the uploaded project already exists in any other version the user account does not need the permission PORTFOLIO_MANAGEMENT.

  • chore: housekeeping

  • chore: fixed README.md

  • chore: fixed SonarQube findings

  • chore: fixed SonarQube findings

  • fix: added parentUuid to put request

  • fix: updated README.md

  • fix: replaced UUID type with String

  • fix: README.md

  • chore: Removed unused import 'java.util.UUID'.

  • Update src/main/java/io/github/pmckeown/dependencytrack/CommonConfig.java

  • chore: implemented review comments


* feat: merge uploadConfig into CommonConfig

* chore: tests successful changes compiled

* feat: respect parentProject in upload request

When the upload request contains correct parent project information separate requests

  1. to check if the parent exists
  2. to move the uploaded project in the tree

could be skipped.
The big advantage is, that admin could separate permissions of teams using the new feature "Portfolio Access Control".

Additionally if the uploaded project already exists in any other version the user account does not need the permission PORTFOLIO_MANAGEMENT.

* chore: housekeeping

* chore: fixed README.md

* chore: fixed SonarQube findings

* chore: fixed SonarQube findings

* fix: added parentUuid to put request

* fix: updated README.md

* fix: replaced UUID type with String

* fix: README.md

* chore: Removed unused import 'java.util.UUID'.

* Update src/main/java/io/github/pmckeown/dependencytrack/CommonConfig.java

Co-authored-by: Paul McKeown <pmckeown@gmail.com>

* chore: implemented review comments

---------

Co-authored-by: Thomas Hucke <thomas.hucke@sopra-ft.com>
Co-authored-by: Paul McKeown <pmckeown@gmail.com>
@github-advanced-security
Copy link
Copy Markdown

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

Comment thread src/main/java/io/github/pmckeown/dependencytrack/upload/UploadBomMojo.java Outdated
chore: updated maven dependencies
@thomashucke
Copy link
Copy Markdown
Contributor

@pmckeown - Would you please check if I could be provided with the permission to directly push my changes?

@pmckeown
Copy link
Copy Markdown
Owner Author

@pmckeown - Would you please check if I could be provided with the permission to directly push my changes?

I’ve added you as a collaborator so should be good to push. Please check.

@sonarqubecloud
Copy link
Copy Markdown

@thomashucke
Copy link
Copy Markdown
Contributor

thomashucke commented Dec 13, 2024

@pmckeown - got it to push.
Please check - I'd appreciate your feedback.

Copy link
Copy Markdown
Owner Author

@pmckeown pmckeown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks! Will get this merged and released.

@pmckeown pmckeown merged commit 202325a into main Dec 14, 2024
@pmckeown pmckeown deleted the feature/consolidate-upload branch December 14, 2024 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants