Skip to content

Conversation

@janekmi
Copy link
Contributor

@janekmi janekmi commented Jul 20, 2023

@janekmi janekmi added the sprint goal This pull request is part of the ongoing sprint label Jul 20, 2023
@janekmi janekmi added this to the 2.0.0 milestone Jul 20, 2023
Copy link
Contributor

@grom72 grom72 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @janekmi)

@janekmi janekmi force-pushed the push-for-forks branch 3 times, most recently from 1b68a99 to 07152fd Compare July 21, 2023 07:54
Copy link
Contributor Author

@janekmi janekmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 2 files reviewed, all discussions resolved (waiting on @grom72)


.github/workflows/ubuntu.yml line 52 at r3 (raw file):

          TEST_BUILD: ${{ matrix.TEST_BUILD }}
          # Pushes to branches on developer forks (please see the caller workflow)
          # won't measure coverage. Coverage is meant to be measured only for

The rule in action: https://github.com/janekmi/pmdk/actions/runs/5619896913/job/15227866208#step:5:17

Copy link
Contributor Author

@janekmi janekmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 2 files reviewed, all discussions resolved (waiting on @grom72)


.github/workflows/ubuntu.yml line 52 at r3 (raw file):

Previously, janekmi (Jan Michalski) wrote…

The rule in action: https://github.com/janekmi/pmdk/actions/runs/5619896913/job/15227866208#step:5:17

The same condition on pull request: https://github.com/pmem/pmdk/actions/runs/5619986031/job/15228109609#step:5:17

@janekmi janekmi removed the sprint goal This pull request is part of the ongoing sprint label Jul 21, 2023
...not maintained on pmem/pmdk

Signed-off-by: Jan Michalski <[email protected]>
Copy link
Contributor

@osalyk osalyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 2 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @janekmi)

@janekmi janekmi modified the milestones: 2.0.0, 2.0.1 Aug 8, 2023
Copy link
Contributor

@grom72 grom72 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 2 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @janekmi)

@janekmi janekmi modified the milestones: 2.0.1, 2.0.2 Nov 23, 2023
@janekmi janekmi modified the milestones: 2.1.0, 2.x Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants