intercept: Abort via the equivalent of raise(SIGABRT) #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we're crashing, raise(SIGABRT) is more debugging-friendly than _exit(1) - that way we'll leave a core dump behind. Signed-off-by: Simon McVittie <[email protected]>
|
Hmm, this makes the tests fail, because some of the tests expect it to be possible to fail to patch a function. Sorry, I'm not sure I understand how those tests ever passed - wouldn't they kill the host process with |
GBuella
reviewed
Jul 12, 2019
| /* abort(), but without using glibc */ | ||
| tid = syscall_no_intercept(SYS_gettid); | ||
| pid = syscall_no_intercept(SYS_getpid); | ||
| syscall(SYS_tgkill, pid, tid, SIGABRT); |
There was a problem hiding this comment.
So, why is it syscall here, and why not syscall_no_intercept?
Your comment says "without glibc", but syscall is a function in libc, which is going to be intercepted actually...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we're crashing, raise(SIGABRT) is more debugging-friendly than _exit(1) - that way we'll leave a core dump behind.
This change is