CF merger #2: introducing porepy.compositional#1186
Conversation
…halpy and scaling issues in ph flash.
MOD: Structuring of initialization MOD: Added h-v- flash to scripts for first publication
MOD: Re-namedsome functionality in chemical interface FIX: Implementation of BIPs for components with custom models
keileg
left a comment
There was a problem hiding this comment.
Minor comments only, I believe. One mentions tests, but that we have discussed already.
Co-authored-by: Eirik Keilegavlen <Eirik.Keilegavlen@uib.no>
|
@keileg Could you please go through all unresolved conversations and mark them resolved if you are satisfied with the changes? |
Co-authored-by: Eirik Keilegavlen <Eirik.Keilegavlen@uib.no>
|
@keileg |
Proposed changes
Introducing modeling of multicomponent and multiphase mixtures.
Introducing also mixin classes which enables user to easily create mixtures and introduce a attribute
fluid_mixtureinto the model.Things to discuss:
fluidconstants: Two options:a. make functionality to build a single-phase, single-component mixture with some simplified EoS from
fluidconstants.b. replace
fluidwith the fluid mixture and start transitioning the model framework to a more general setting. On a side node, a similar discussion will be required when introducing the compositional flow equations (relation to current single phase flow etc).Types of changes
Unrelated changes: Overload of logical operators in
forward_mode.AdArray. I think this is required in some point of the new code.Bugfix: Fixing memory leak in surrogate operator (require depth parameter for shifting values in time and iterate sense, otherwise excessive storage)
Checklist
pytestwas run with the--run-skippedflag.For the record
This PR contains some fixes in numba-compiled functions (related to casting and signature typing), which were discovered in some completely unrelated context.