Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEAT: Add remove_variables method to EquationSystem #1321

Merged
merged 5 commits into from
Feb 6, 2025

Conversation

IvarStefansson
Copy link
Contributor

Proposed changes

The new method updates the attributes set during create_variable, removing everything related to the variables to be removed.

Types of changes

What types of changes does this PR introduce to PorePy?
Put an x in the boxes that apply.

  • Minor change (e.g., dependency bumps, broken links).
  • Bugfix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).
  • Testing (contribution related to testing of existing or new functionality).
  • Documentation (contribution related to adding, improving, or fixing documentation).
  • Maintenance (e.g., improve logic and performance, remove obsolete code).
  • Other:

Checklist

Put an x in the boxes that apply or explain briefly why the box is not relevant.

  • The documentation is up-to-date.
  • Static typing is included in the update.
  • This PR does not duplicate existing functionality.
  • The update is covered by the test suite (including tests added in the PR).
  • If new skipped tests have been introduced in this PR, pytest was run with the --run-skipped flag.

Copy link
Contributor

@keileg keileg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Main question: What happens to the stored variable state when a variable is removed? I think this needs to be updated, or else all kind of things will break. Am I missing something?

src/porepy/numerics/ad/equation_system.py Show resolved Hide resolved
src/porepy/numerics/ad/equation_system.py Outdated Show resolved Hide resolved
src/porepy/numerics/ad/equation_system.py Show resolved Hide resolved
tests/numerics/ad/test_equation_system.py Show resolved Hide resolved
@IvarStefansson IvarStefansson merged commit d85f446 into develop Feb 6, 2025
6 checks passed
@IvarStefansson IvarStefansson deleted the FEAT-EquationSystem-remove_variable branch February 6, 2025 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants