Skip to content

removed double declaration and assignment#111

Merged
glessin merged 6 commits intomasterfrom
110-double-diag-nitrifcation
Aug 21, 2024
Merged

removed double declaration and assignment#111
glessin merged 6 commits intomasterfrom
110-double-diag-nitrifcation

Conversation

@yutiPML
Copy link
Copy Markdown
Collaborator

@yutiPML yutiPML commented Jul 6, 2023

Description of Work

Fixes

Testing Instructions

@yutiPML yutiPML requested a review from glessin July 6, 2023 15:37
@yutiPML yutiPML linked an issue Jul 6, 2023 that may be closed by this pull request
Copy link
Copy Markdown
Member

@glessin glessin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change line 60: 'rate' to 'nitrification rate' (both name and long_name) and add 'N' to units (i.e. 'mmol N').
But maybe we better keep the id_N4N3n rather than 'id_nitrification' for consistency with N4O5n?

@wathen
Copy link
Copy Markdown
Member

wathen commented Jul 16, 2024

@yutiPML and @glessin, is this ready for review? Also, is there an issue number to add to the PR?

@yutiPML yutiPML marked this pull request as draft July 24, 2024 10:13
@yutiPML yutiPML marked this pull request as ready for review July 24, 2024 11:44
@glessin glessin merged commit 9dcbee9 into master Aug 21, 2024
@wathen wathen deleted the 110-double-diag-nitrifcation branch January 26, 2026 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

double diagnostic in nitrification.F90

3 participants