replace add_dependencies with target_link_libraries to support parallel ninja builds#124
Merged
glessin merged 3 commits intopmlmodelling:masterfrom Jun 25, 2024
Merged
replace add_dependencies with target_link_libraries to support parallel ninja builds#124glessin merged 3 commits intopmlmodelling:masterfrom
glessin merged 3 commits intopmlmodelling:masterfrom
Conversation
Member
|
@jornbr is this ready for review? |
glessin
approved these changes
Jun 25, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Work
This replaces cmake's
add_dependencieswithtarget_link_libraries. This is in line with FABM 2.0 conventions and required to support parallel builds with ninja. Specifically, this PR fixes this test failure. The change is compatible with all FABM versions; it just requires cmake 3.13, which was released over 5 years ago and therefore widely available.