Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

moved getting om_cal only if ISWCAL not equal to 0 #98

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

moved getting om_cal only if ISWCAL not equal to 0 #98

wants to merge 6 commits into from

Conversation

yutiPML
Copy link
Collaborator

@yutiPML yutiPML commented Nov 9, 2022 •
edited by glessin
Loading

when ISWCAL=0 the dependency is not defined (because is not needed)

Description of Work

Fixes #95

Testing Instructions

  1. raise atmospheric pCO2 to 2000 (as the difference is noticed only for low O3_om_cal)
  2. run GOTM-ERSEM with normal fabm.yaml
  3. run GOTM-ERSEM setting ISWCAL to 0, set new parameter fdiss to the same value of fdissmin, comment definitions of parameters fdissmax, ndiss, fidssmin and the coupling to O3/om_cal
  4. compare the result (run with ISWCAL = 0 has higher bL2_c)

@yutiPML
moved getting om_cal only if ISWCAL not equal to 0
596d710 
when ISWCAL=0 the dependency is not defined (because is not needed)
@yutiPML yutiPML linked an issue Nov 9, 2022 that may be closed by this pull request
code breaks if iswcal=0 #95
Open
@yutiPML yutiPML marked this pull request as ready for review November 9, 2022 10:53
@yutiPML
Copy link
Collaborator Author

yutiPML commented Nov 9, 2022

ready for review as soon as the test on pyfabm is fixed

@yutiPML yutiPML requested a review from glessin November 11, 2022 12:19
@yutiPML yutiPML self-assigned this Nov 11, 2022
@yutiPML yutiPML added the bug Something isn't working label Nov 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glessin glessin Awaiting requested review from glessin

At least 1 approving review is required to merge this pull request.

Assignees

@yutiPML yutiPML

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

code breaks if iswcal=0
2 participants
@yutiPML @wathen