Fix creative drop when breaking block #4652
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dktapps
previously requested changes
Dec 15, 2021
Co-authored-by: Dylan T. <[email protected]>
ColinHDev
reviewed
Dec 15, 2021
dktapps
added
Category: Gameplay
jasonw4331
approved these changes
Jul 17, 2023
IvanCraft623
force-pushed
the
creativeDrop
branch
from
26f1a27 to
55f3d61
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
dries-c
previously approved these changes
Aug 20, 2024
Joshy3282
added a commit
to Joshy3282/PocketMine-MP
that referenced
this pull request
Oct 1, 2024
|
I had a bad gut reaction to this. I feel like there should be a better way to deal with this. Not thrilled about the prospect of adding another drops function. I know this isn't the most helpful comment, which is why I hesitated to re-review it. I'll circle back if there's interest in getting this completed. |
dktapps
added
the
Opinions Wanted
|
Seems to be also linked to #4451 |
…MP into creativeDrop
![pmmp-admin-bot[bot]](https://avatars.githubusercontent.com/in/1059952?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduction
As it is well explained in the related issue, creative players when they break a sulker or an oven with xp, they will not drop the xp or the item while the vanilla gameplay allows it
Relevant issues
Changes
API changes
The following methods have been added to the
Blockclass:getCreativeDropsgetCreativeXpDropBehavioural changes
When a block is broken by a player or other, it will make the difference to get the right drops. If the player is creative, he will call the necessary functions, if it is an explosion ditto
Tests