-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Items that have contents now drops them on destroy #4768
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
JavierLeon9966
wants to merge
21
commits into
pmmp:minor-next
Choose a base branch
from
JavierLeon9966:item-drop-contents
base: minor-next
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 7 commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
ce9a2b9
Items that have contents now drops them on death
JavierLeon9966 027e8e1
Merge branch 'stable' into item-drop-contents
dktapps 4b918aa
Added `Item::getContainedItems()` and `Item::setContainedItems()`
JavierLeon9966 1168d47
Fixed syntax error
JavierLeon9966 135781c
Fixed CS
JavierLeon9966 1ab9e4b
Merge branch 'next-minor' into item-drop-contents
JavierLeon9966 f1701a5
Merge remote-tracking branch 'origin/minor-next' into item-drop-contents
JavierLeon9966 ee86b51
Fixed items not preserving their slot positions
JavierLeon9966 28ae2d7
Extracted item contents serialization code
JavierLeon9966 bbbaf7e
Fixed PHPStan error
JavierLeon9966 d9fcbc7
Fix CS
JavierLeon9966 8d9e14d
Fix CS (again)
JavierLeon9966 6d47810
Make chiseled bookshelves use their own items serialization
JavierLeon9966 9628fbf
Include more item containers to be dropped upon destroy
JavierLeon9966 90d2432
Fix CS
JavierLeon9966 074cf27
Fix CS
JavierLeon9966 b0f1347
Merge remote-tracking branch 'fork/item-drop-contents' into item-drop…
JavierLeon9966 039105f
Renamed "util" folder to "utils" for consistency
JavierLeon9966 1582f95
Merge branch 'minor-next' into item-drop-contents
dktapps 1ba57de
Clone the contained items before setting them
JavierLeon9966 d3e45f7
Merge branch 'minor-next' into item-drop-contents
JavierLeon9966 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.