Save and read CustomNameAlwaysVisible tag

[IvanCraft623]

Introduction

The CustomNameAlwaysVisible tag is not being read/saved in the entities, causing data loss.

Relevant issues

• Fixes Nametag visibility is not persisted #4669

Tests

$human = new Human($location, $skin);
$human->setNameTag("mctestDylan");
$human->setNameTagAlwaysVisible();

[ColinHDev]

Do we follow Mojang's entity save format within PM? Just asking because a save key with a comparable functionality does not exist according to the wiki.

[dktapps]

Do we follow Mojang's entity save format within PM? Just asking because a save key with a comparable functionality does not exist according to the wiki.

That's precisely why I hesitated to merge it.

[ShockedPlot7560]

I don't think this should be an obstacle to merge the PR. Could it have any impact on PM at some point?

[dktapps]

I don't think this should be an obstacle to merge the PR. Could it have any impact on PM at some point?

As long as we're sure Mojang won't introduce a tag with the same name and a different value type...

[dktapps]

I think we need to think about standard ways to store PM-specific data before merging this, so this doesn't become a problem in the future. (Really should've done this years ago before plugin devs were able to start injecting all kinds of crap into the NBT...)

[ipad54]

I think we need to think about standard ways to store PM-specific data before merging this, so this doesn't become a problem in the future.

The first thing that comes to mind is to have a PMMPExtraData Compound tag that will be written into an entity NBT and also loadExtraData(CompoundTag $nbt) : void, saveExtraData() : CompoundTag methods. Any custom entity properties will be stored inside this tag. What do you think?

[dktapps]

@ipad54 I agree with putting PM custom data inside a subtag. Not sure if it's necessary to add extra methods for it though since it won't be needed in most cases.

[ipad54]

Extra methods can be pretty useful in the future if we want to store more than one custom property, especially in different entity classes.

[dktapps]

I feel like it's redundant for one property. We can add more stuff later on if necessary.