Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: stateless useFiber, ContextBridge #32

Closed
wants to merge 6 commits into from

Conversation

CodyJasonBennett
Copy link
Member

Refactors useFiber and useContextBridge to not depend on our favorite export. traverseFiber is renamed to traverse with ascending moved beyond the selector, and removes FiberProvider and the unused useNearestChild, useNearestParent, and useContextMap hooks.

@itsdouges
Copy link

itsdouges commented Nov 3, 2023

@CodyJasonBennett what's the plan with this? I'm going to spend some time investigating its fine this afternoon. Curious to know if this will come in soon.

Not needing the fiber provider looks like a great change. I'm going to copy this and have a play.

Edit: It doesn't look like it works 100% of the time. Mostly needing to re-render/HMR to find expected meshes. Is it not concurrent mode safe I guess? Let me test without suspending.

Edit (2): Yes that seems to be the problem.

@CodyJasonBennett
Copy link
Member Author

Will backport as a minor release.

@CodyJasonBennett CodyJasonBennett deleted the experiment/min branch April 9, 2024 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants