Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sidestep react-server warnings for layout effects #35

Merged
merged 1 commit into from
Apr 9, 2024
Merged

fix: sidestep react-server warnings for layout effects #35

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 16 additions & 2 deletions src/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,20 @@
import * as React from 'react'
import type ReactReconciler from 'react-reconciler'

/**
* An SSR-friendly useLayoutEffect.
*
* React currently throws a warning when using useLayoutEffect on the server.
* To get around it, we can conditionally useEffect on the server (no-op) and
* useLayoutEffect elsewhere.
*
* @see https://github.com/facebook/react/issues/14927
*/
const useIsomorphicLayoutEffect =
typeof window !== 'undefined' && (window.document?.createElement || window.navigator?.product === 'ReactNative')
? React.useLayoutEffect
: React.useEffect

/**
* Represents a react-internal Fiber node.
*/
Expand Down Expand Up @@ -145,7 +159,7 @@ export function useNearestChild<T = any>(
const fiber = useFiber()
const childRef = React.useRef<T>()

React.useLayoutEffect(() => {
useIsomorphicLayoutEffect(() => {
childRef.current = traverseFiber<T>(
fiber,
false,
Expand All @@ -168,7 +182,7 @@ export function useNearestParent<T = any>(
const fiber = useFiber()
const parentRef = React.useRef<T>()

React.useLayoutEffect(() => {
useIsomorphicLayoutEffect(() => {
parentRef.current = traverseFiber<T>(
fiber,
true,
Expand Down
Loading