Skip to content

test({react,vanilla}): migrate to vitest fake timers with adding 'loading' assertions, replace 'userEvent'/'findByText' with 'fireEvent'/'getByText', and remove 'waitFor' #3147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 12 commits into
base: main
Choose a base branch
from
Draft

test({react,vanilla}): migrate to vitest fake timers with adding 'loading' assertions, replace 'userEvent'/'findByText' with 'fireEvent'/'getByText', and remove 'waitFor' #3147

wants to merge 12 commits into from

Conversation

sukvvon
Copy link
Contributor

@sukvvon sukvvon commented Sep 13, 2025 •
edited
Loading

Related Bug Reports or Discussions

Fixes #

Summary

remove waitFor

  • react
    • vanilla-utils
      • atomFamily
      • atomWithDefault
    • dependency
    • items
    • onmount
    • optimization
    • provider
    • useSetAtom

replace findByText with getByText

  • react
    • vanilla-utils
      • atomFamily
      • atomWithDefault
      • atomWithReducer
      • atomWithRefresh
    • dependency
    • items
    • onmount
    • optimization
    • useAtomValue

replace userEvent with fireEvent

  • react
    • vanilla-utils
      • atomFamily
      • atomWithDefault
      • atomWithReducer
      • atomWithRefresh
    • dependency
    • items
    • onmount
    • optimization
    • useAtomValue
    • useSetAtom

migrate to vitest fake timers with adding loading assertions

  • react
    • vanilla-utils
      • atomFamily
      • atomWithDefault
      • atomWithRefresh
    • dependency
    • onmount
    • useAtomValue

Check List

  • pnpm run fix for formatting and linting code and docs

@vercel Vercel
Copy link

vercel bot commented Sep 13, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
jotai Ready Ready Preview Comment Sep 22, 2025 0:36am

@codesandbox-ci CodeSandbox CI
Copy link

codesandbox-ci bot commented Sep 13, 2025 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Sep 13, 2025 •
edited
Loading

More templates

npm i https://pkg.pr.new/jotai@3147

commit: 56c178a

@sukvvon sukvvon force-pushed the test/migrate-to-vitest-fake-timer branch from bae4b43 to 93723d9 Compare September 13, 2025 14:09
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 13, 2025 •
edited
Loading

LiveCodes Preview in LiveCodes

Latest commit: 56c178a
Last updated: Sep 22, 2025 12:35am (UTC)

Playground Link
React demo https://livecodes.io?x=id/8BA34CV3Y

See documentations for usage instructions.

@sukvvon sukvvon force-pushed the test/migrate-to-vitest-fake-timer branch from 5d220f5 to 80e3043 Compare September 13, 2025 14:20
@sukvvon
test(react/useAtomValue): replace 'userEvent' with 'fireEvent', 'find…
9c44611 
…ByText' with 'getByText', and add fake timers
@sukvvon sukvvon force-pushed the test/migrate-to-vitest-fake-timer branch from 80e3043 to 9c44611 Compare September 13, 2025 14:24
@sukvvon sukvvon force-pushed the test/migrate-to-vitest-fake-timer branch from 0fc2d0e to c93671a Compare September 13, 2025 14:32
@sukvvon
test(react/optimization): replace 'userEvent' with 'fireEvent', 'find…
c871edf 
…ByText' with 'getByText', and remove 'waitFor'
@sukvvon sukvvon force-pushed the test/migrate-to-vitest-fake-timer branch from 4c297c0 to c871edf Compare September 13, 2025 14:46
@sukvvon sukvvon force-pushed the test/migrate-to-vitest-fake-timer branch from 9643b35 to 7f52e9e Compare September 13, 2025 15:42
@sukvvon sukvvon force-pushed the test/migrate-to-vitest-fake-timer branch from 7f52e9e to 4d9a53c Compare September 13, 2025 15:50
@sukvvon
test(react/onmount): replace 'userEvent' with 'fireEvent', 'findByTex…
1c953e2 
…t' with 'getByText', add fake timer, and remove 'waitFor'
@sukvvon sukvvon force-pushed the test/migrate-to-vitest-fake-timer branch from 4d9a53c to 1c953e2 Compare September 13, 2025 15:55
@sukvvon sukvvon force-pushed the test/migrate-to-vitest-fake-timer branch from 6a37f73 to 81d53d3 Compare September 14, 2025 06:22
@sukvvon
test(react/dependency): replace 'userEvent' with 'fireEvent', 'findBy…
f6140d4 
…Text' with 'getByText', add fake timer, and remove 'waitFor'
@sukvvon sukvvon force-pushed the test/migrate-to-vitest-fake-timer branch from 81d53d3 to f6140d4 Compare September 14, 2025 06:26
@sukvvon
test(react/vanilla-utils/atomFamily): replace 'userEvent' with 'fireE…
1e1686e 
…vent', 'findByText' with 'getByText', add fake timer, and remove 'waitFor'
@sukvvon sukvvon force-pushed the test/migrate-to-vitest-fake-timer branch from 8a46c27 to 1e1686e Compare September 14, 2025 13:14
@sukvvon
test(react/vanilla-utils/atomWithDefault): replace 'userEvent' with '…
5a0345a 
…fireEvent', 'findByText' with 'getByText', add fake timer, and remove 'waitFor'
@sukvvon sukvvon changed the title test(*): migrate to vitest fake timers test(*): migrate to vitest fake timers, replace 'userEvent' with 'fireEvent', 'findByText' with 'getByText', and remove 'waitFor' Sep 14, 2025
@sukvvon sukvvon changed the title test(*): migrate to vitest fake timers, replace 'userEvent' with 'fireEvent', 'findByText' with 'getByText', and remove 'waitFor' test(*): migrate to vitest fake timers with adding 'loading' asserts, replace 'userEvent' with 'fireEvent', 'findByText' with 'getByText', and remove 'waitFor' Sep 14, 2025
@sukvvon sukvvon changed the title test(*): migrate to vitest fake timers with adding 'loading' asserts, replace 'userEvent' with 'fireEvent', 'findByText' with 'getByText', and remove 'waitFor' test(*): migrate to vitest fake timers with adding 'loading' assertions, replace 'userEvent' with 'fireEvent', 'findByText' with 'getByText', and remove 'waitFor' Sep 14, 2025
@sukvvon sukvvon changed the title test(*): migrate to vitest fake timers with adding 'loading' assertions, replace 'userEvent' with 'fireEvent', 'findByText' with 'getByText', and remove 'waitFor' test(*): migrate to vitest fake timers with adding 'loading' assertions, replace 'userEvent'/'findByText' with 'fireEvent'/'getByText', and remove 'waitFor' Sep 14, 2025
@sukvvon
test(react/vanilla-utils/atomWithRefresh): replace 'userEvent' with '…
f94ed77 
…fireEvent', 'findByText' with 'getByText', and add fake timer
@sukvvon sukvvon changed the title test(*): migrate to vitest fake timers with adding 'loading' assertions, replace 'userEvent'/'findByText' with 'fireEvent'/'getByText', and remove 'waitFor' test({vanilla,react}): migrate to vitest fake timers with adding 'loading' assertions, replace 'userEvent'/'findByText' with 'fireEvent'/'getByText', and remove 'waitFor' Sep 14, 2025
@sukvvon sukvvon changed the title test({vanilla,react}): migrate to vitest fake timers with adding 'loading' assertions, replace 'userEvent'/'findByText' with 'fireEvent'/'getByText', and remove 'waitFor' test({react,vanilla}): migrate to vitest fake timers with adding 'loading' assertions, replace 'userEvent'/'findByText' with 'fireEvent'/'getByText', and remove 'waitFor' Sep 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@sukvvon