Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v5] breaking: drop deprecated features #2235

Merged
merged 11 commits into from
Dec 14, 2023
Merged

[v5] breaking: drop deprecated features #2235

merged 11 commits into from
Dec 14, 2023

Conversation

charkour
Copy link
Collaborator

@charkour charkour commented Dec 9, 2023 •
edited
Loading

Summary

Check List

  • yarn run prettier for formatting code and docs
  • Update documentation to remove references to dropped features

@vercel Vercel
Copy link

vercel bot commented Dec 9, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
zustand-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 14, 2023 4:38am

charkour
charkour commented Dec 9, 2023
View reviewed changes
tests/shallow.test.tsx Outdated Show resolved Hide resolved
@charkour charkour changed the title [v5]breaking: drop deprecated features [v5] breaking: drop deprecated features Dec 9, 2023
@codesandbox-ci CodeSandbox CI
Copy link

codesandbox-ci bot commented Dec 9, 2023 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 568438b:

Sandbox Source
React Configuration
React TypeScript Configuration
React Browserify Configuration
React Snowpack Configuration
React Parcel Configuration
Next.js Configuration
@pavlobu/zustand demo Configuration

charkour
charkour commented Dec 9, 2023
View reviewed changes
docs/guides/typescript.md Outdated Show resolved Hide resolved
@charkour charkour marked this pull request as ready for review December 9, 2023 05:11
@TheMikeyRoss
Copy link

@charkour you're on fire 🔥 I appreciate your work ♥

@charkour
Copy link
Collaborator Author

charkour commented Dec 9, 2023

Thank you for the support, @TheMikeyRoss 😁

@charkour charkour mentioned this pull request Dec 9, 2023
Merged
1 task
@dai-shi dai-shi mentioned this pull request Dec 10, 2023
Open
16 tasks
@charkour charkour mentioned this pull request Dec 10, 2023
Merged
1 task
@charkour charkour marked this pull request as draft December 10, 2023 15:53
@charkour
Copy link
Collaborator Author

I'll convert this to a draft while fixing the upstream changes.

charkour
charkour commented Dec 10, 2023
View reviewed changes
package.json Show resolved Hide resolved
charkour
charkour commented Dec 10, 2023
View reviewed changes
src/react.ts Show resolved Hide resolved
@charkour charkour marked this pull request as ready for review December 10, 2023 16:11
@charkour charkour marked this pull request as draft December 12, 2023 18:11
@charkour charkour marked this pull request as ready for review December 14, 2023 05:11
dai-shi
dai-shi approved these changes Dec 14, 2023
View reviewed changes
Copy link
Member

@dai-shi dai-shi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@dai-shi dai-shi merged commit 6f99da1 into pmndrs:v5 Dec 14, 2023
3 checks passed
@charkour charkour deleted the v5-remove-deprecated branch December 14, 2023 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheMikeyRoss TheMikeyRoss TheMikeyRoss left review comments

@dai-shi dai-shi dai-shi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@charkour @TheMikeyRoss @dai-shi