Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v5]: do not depend on use-sync-external-store #2301

Merged
merged 2 commits into from
Jan 20, 2024
Merged

[v5]: do not depend on use-sync-external-store #2301

merged 2 commits into from
Jan 20, 2024

Conversation

dai-shi
Copy link
Member

@dai-shi dai-shi commented Jan 20, 2024

for #2138

Just forgot it in #2237 (comment)

Copy link

vercel bot commented Jan 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
zustand-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 20, 2024 6:38am

Copy link

codesandbox-ci bot commented Jan 20, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 9823aa5:

Sandbox Source
React Configuration
React TypeScript Configuration
React Browserify Configuration
React Snowpack Configuration
React Parcel Configuration
Next.js Configuration
@pavlobu/zustand demo Configuration

Copy link

github-actions bot commented Jan 20, 2024

Size Change: +71 B (+1%)

Total Size: 9.04 kB

Filename Size Change
dist/index.js 600 B +71 B (+13%) ⚠️
ℹ️ View Unchanged
Filename Size
dist/middleware.js 4.08 kB
dist/middleware/immer.js 328 B
dist/react/shallow.js 1.07 kB
dist/shallow.js 1.08 kB
dist/traditional.js 464 B
dist/vanilla.js 436 B
dist/vanilla/shallow.js 969 B

compressed-size-action

Copy link
Collaborator

@charkour charkour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this.

We need to keep use-sync-external-store in traditional.ts to support the selector API, correct?

@dai-shi
Copy link
Member Author

dai-shi commented Jan 20, 2024

Yes, not for selector but for equalityFn.

@dai-shi
Copy link
Member Author

dai-shi commented Jan 20, 2024

Warning: The result of getServerSnapshot should be cached to avoid an infinite loop

I see...

@dai-shi
Copy link
Member Author

dai-shi commented Jan 20, 2024

image

@dai-shi dai-shi merged commit 6c9944b into v5 Jan 20, 2024
22 checks passed
@dai-shi dai-shi deleted the v5-remove-uSES branch January 20, 2024 06:46
@dai-shi dai-shi mentioned this pull request Feb 17, 2024
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants