Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spack CPU build exago~mpi #47

Closed
wants to merge 6 commits into from
+61 −58
Closed

Spack CPU build exago~mpi #47

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
08a713f
Add back Spack CPU builds to reproduce issues
Oct 13, 2023
a014957
Use container's spack and load spack binary cache
Oct 16, 2023
aec2713
Only check for Python if Python is enabled
Oct 16, 2023
64c9d64
Properly check for tests/MPI in including Python wrapper extensions
Oct 16, 2023
51d6802
Apply pre-commmit fixes
cameronrutherford Oct 16, 2023
6dcc180
Update exago_python.hpp to conditionally include mpi4py
Oct 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Add back Spack CPU builds to reproduce issues
Cameron Rutherford authored Oct 13, 2023
commit 08a713fdf80d04c940e198277958f2ad9fa341f2
13 changes: 5 additions & 8 deletions .github/workflows/spack_cpu_build.yaml
View file
Original file line number Diff line number Diff line change
@@ -14,17 +14,14 @@ jobs:
# Minimal Build(s)
# Need S3 mirror to have these builds speedup
spack_spec:
# See #39 - ~python~mpi causes issues
# - exago@develop~mpi~ipopt~hiop~python~raja
# See #44 - +mpi~python should fail if no python in system,
# but the runner happens to have one...
- exago@develop+mpi~ipopt+hiop~python~raja ^openmpi
# See #39 - minimal build useful for sanity
- exago@develop~mpi~ipopt~hiop~python~raja
# See #16 / #44 - +python~mpi catches mpi4py / python config
- exago@develop~mpi~ipopt~hiop+python~raja
Comment on lines +17 to +20
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Issue in +mpi~python should be equivalent to a build with ~mpi~python as far as I can tell. Either way I think this is sufficient and we need to ensure these builds pass in future.

# See #18 - +hiop~mpi causes issues
# - exago@develop~mpi~ipopt+hiop~python+raja
# See #16 - +python~mpi causes issues
# - exago@develop~mpi~ipopt+hiop+python~raja
- exago@develop+mpi~ipopt+hiop+python~raja ^openmpi
# See #40 - +hiop+raja~ipopt ^hiop~sparse is useful for edge cases
# See #40 - +hiop+raja~ipopt ^hiop~sparse is useful for edge cases in xSDK
- exago@develop+mpi~ipopt+hiop~python+raja ^openmpi ^hiop+raja~sparse

name: Build ExaGO with Spack