-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python Measure Unit Test Action #19
base: master
Are you sure you want to change the base?
Conversation
jslane-h
commented
Nov 20, 2024
- Action to run tests on Python measures
- Fixed bug in GenerateConStrainReport measure
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
@jslane-h - Could we perhaps also run a measure check using the openstudio measure -t <path/to/lib/measures>
after installing openstudio
with pip? I know that some error are expected but perhaps we could filter the ones that are expected and fail the build if other appears.
It looks like the CLI isn't installed when pip installing openstudio. I tried manually installing openstudio and got an error that I'm guessing is due to its size. Using docker might be a good strategy here. Any suggestions? |
RUN wget https://github.com/NREL/OpenStudio/releases/download/v3.9.0/OpenStudio-3.9.0+c77fbb9569-Ubuntu-22.04-x86_64.tar.gz && \ | ||
tar -xvzf OpenStudio-3.9.0+c77fbb9569-Ubuntu-22.04-x86_64.tar.gz && \ | ||
cp -r OpenStudio-3.9.0+c77fbb9569-Ubuntu-22.04-x86_64/usr/local/openstudio-3.9.0 /usr/local/openstudio |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@weilixu - should we always test using the latest version of OpenStudio?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure - I guess it should depends on the measure dependency. If all measures move at the same pace, we can use the latest OS version for testing.
@lymereJ @weilixu I found a way to add an auto-commit if we run 'openstudio measure -t ...' and changes are made to the XML's. Would this be helpful? I originally wanted to fail if changes are detected, but this ran into an issue with the python measure XMLs since |