RS/YJ/Rule 22-12 #1156
Merged
RS/YJ/Rule 22-12 #1156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weilixu
reviewed
Oct 10, 2023
| if getattr_(heat_rejection_b, "heat_rejections", "loop") | ||
| in heat_rejection_loop_ids_b | ||
| ] | ||
| ) |
There was a problem hiding this comment.
Another way to do it could be:
number_of_baseline_heat_rejections_b = len(
[
heat_rejection_b
for heat_rejection_b in find_all("$.heat_rejections[*]", rmd_b)
if getattr_(heat_rejection_b, "heat_rejections", "loop")
in heat_rejection_loop_ids_b
]
)There was a problem hiding this comment.
Good point! Addressed.
| "number_of_baseline_heat_rejections_b": number_of_baseline_heat_rejections_b, | ||
| } | ||
|
|
||
| class HeatRejectionRule(RuleDefinitionBase): |
There was a problem hiding this comment.
I don't think you need this nested class.
This can be done at the rule level.
There was a problem hiding this comment.
Good point! Addressed.
| number_of_baseline_heat_rejections_b == 1 | ||
| and len_heat_rejection_loop_ids_b > 1 | ||
| ): | ||
| FAIL_MSG = "There is more than one condenser loop for this building. There should only be one condenser loop attached to all chillers in the baseline chiller plant." |
There was a problem hiding this comment.
This should not be the building, but the project.
Let's update the message to:
"There is more than one condenser loop for this project. There should only be one condenser loop attached to all chillers in the baseline chiller plant."
There was a problem hiding this comment.
Addressed.
weilixu
approved these changes
Oct 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This rule was tested with Juan's TCD from PR #1155. I included the TCD here. Thanks!