-
Notifications
You must be signed in to change notification settings - Fork 358
docs: add minimal permissions for entra organization list command #6961
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
docs: add minimal permissions for entra organization list command #6961
Conversation
- Added Permissions section to organization-list.mdx - Documents Organization.Read.All and User.Read permissions for both delegated and application auth - Closes pnp#6947
Hi @URAYUSHJAIN , the issue specified 2 commands, but this PR contains only 1 command. Could you add the |
The organization-set command already has the Permissions section properly documented in the main branch with Organization.ReadWrite.All for both delegated and application permissions. Both commands in issue pnp#6947 are now covered: - organization-list: Added permissions (new) - organization-set: Already had permissions (confirmed)
@Jwaegebaert sir Good catch! I've reviewed both commands: ✅ organization-list: Added permissions in this PR Added a commit to confirm I've reviewed both. Both commands in #6947 are now covered! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great start @URAYUSHJAIN! I've left a few remarks you can take a look at.
|
||
| Resource | Permissions | | ||
|-----------------|--------------------------------------------------| | ||
| Microsoft Graph | Organization.Read.All, User.Read | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Application context can't contain "user.read" permissions
| Microsoft Graph | Organization.Read.All, User.Read | | |
| Microsoft Graph | Organization.Read.All | |
@Jwaegebaert plz merge |
First, take a look at the remarks I've left before we can merge these changes @URAYUSHJAIN |
|
||
:::info | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@URAYUSHJAIN, One more note here. Let's move this admonition below the permissions tab.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Jwaegebaert sir done
Uh oh!
There was an error while loading. Please reload this page.