Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update spfx samples for mgt v4 #14

Merged
merged 6 commits into from
Feb 29, 2024
Merged

Conversation

gavinbarron
Copy link
Collaborator

By submitting this pull request, you agree to the contribution guidelines

If you aren't familiar with how to contribute to open-source repositories using GitHub, or if you find the instructions on this page confusing, sign up for one of our Sharing is Caring events. It's completely free, and we'll guide you through the process.

Q A
Bug fix? no
New feature? yes
New sample? no
Related issues? fixes #X, partially #Y, mentioned in #Z

What's in this Pull Request?

Removes dynamic import in sp-mgt
Updates gulp files to patch webpack config to handle new lit dependencies

Copy link
Collaborator Author

@gavinbarron gavinbarron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noting changes that will need to be made after MGT v4 releases and before merging.

samples/app/sp-mgt/package.json Outdated Show resolved Hide resolved
samples/app/sp-webpart/package.json Outdated Show resolved Hide resolved
@gavinbarron gavinbarron marked this pull request as ready for review February 6, 2024 01:38
Copy link
Collaborator

@sebastienlevert sebastienlevert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gavinbarron let's update this one with the latest discussions with path on Windows. Then I think we're good to go for merging.

@gavinbarron
Copy link
Collaborator Author

@sebastienlevert I've updated the gulpfiles to use path.sep so I think this is good to go

@sebastienlevert sebastienlevert merged commit 2b1caec into main Feb 29, 2024
1 check passed
This was referenced Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants