Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sharing power automate samples #92

Merged

Conversation

Solanki-Manish
Copy link
Contributor

By submitting this pull request, you agree to the contribution guidelines

If you aren't familiar with how to contribute to open-source repositories using GitHub, or if you find the instructions on this page confusing, sign up for one of our Sharing is Caring events. It's completely free, and we'll guide you through the process.

To submit a pull request with multiple authors, make sure that at least one commit is a co-authored commit by adding a Co-authored-by: trailer to the commit's message. E.g.: Co-authored-by: name <[email protected]>

Put an x in all the items that apply ([x], without spaces), make notes next to any that haven't been addressed.

  • Bug fix?
  • New sample?
  • Related issues: fixes #X, partially #Y, mentioned in #Z
  • Needs API permissions?
  • Has other prerequisites? (E.g. requires a list, document library, etc.)

What's in this Pull Request?

A sample to overcome 28 KB payload size limit for embedding an image in Microsoft Teams channel message using standard action in Power Automate.

Checklist

This checklist is mostly useful as a reminder of small things that can easily be forgotten – it is meant as a helpful tool rather than hoops to jump through.

Put an x in all the items that apply ([x], no spaces), make notes next to any that haven't been addressed.

  • My pull request affects only ONE sample.
  • I have updated the README file.
  • My README has at least one static high-resolution screenshot (i.e. not a GIF)
  • My README contains complete setup instructions, including pre-requisites and permissions required

@Katerina-Chernevskaya Katerina-Chernevskaya added the Needs Attention Something needs to be fixed with the PR before merging label Jun 4, 2024
@Katerina-Chernevskaya
Copy link
Contributor

Hi @Solanki-Manish ,

Thank you for your contribution!

I've tried to create a solution from the source code and got the error:
image
It seems that some files are missing from the source code. Please update it according to the guideline and let me know once it is ready. I'll be happy to review and merge it!

Thank you!

@Katerina-Chernevskaya Katerina-Chernevskaya removed the Needs Attention Something needs to be fixed with the PR before merging label Jun 18, 2024
Copy link
Contributor

@Katerina-Chernevskaya Katerina-Chernevskaya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Solanki-Manish

Thank you for the contribution! I've created the solution and added the sample.json file.
I'm going to merge the PR.
Just a minor improvement for the future - please consider to move dynamic values (like SharePoint site, etc.) to the environment variables. This will make the import process strightforward, following best practices and exclude edit flow dtep.

Thanks again!

Regards,
Kate

@Katerina-Chernevskaya Katerina-Chernevskaya merged commit bc40ec1 into pnp:main Jun 18, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants