Fix #1721 #1722

nsoeth · 2023-12-07T14:51:39Z

Q	A
Bug fix?	[ ]
New feature?	[ ]
New sample?	[x]
Related issues?	fixes #X, partially #Y, mentioned in #Z

What's in this Pull Request?

This PR will fix #1721

Guidance

You can delete this section when you are submitting the pull request.
Please update this PR information accordingly. We'll use this as part of our release notes in monthly communications.
Please target your PR to dev branch.

github-actions

Thank you for the first contribution to this project.

michaelmaillot · 2024-02-08T17:24:30Z

Hi @nsoeth,

Thanks for this PR!

Regarding the addition of $top query operation, I'd suggest to make it available as optional because it depends on use case and maybe it would not fit for everyone to load 5000 items at once.

Since the DynamicForm lookup field relies on ListItemPicker control, and in order to be available as a field override prop for the DynamicForm, here are the different files to update according to me:

SPService.ts
IListItemPieckerProps
ListItemPicker (ListItemPickercontrol doc will have to be updated as there will be a new prop available)
IDynamicFieldProps
DynamicField

Like this, the developer will be free to set the number of items he wants to get 🙂

A suggestion of prop name could be itemsQueryCountLimit or ODataTopCount for example but feel free to suggest!

Let me know if something's not clear or if you need help.

nsoeth · 2024-02-27T13:32:37Z

Hi @michaelmaillot ,
Thanks for your suggestions, I updated the PR.

Kind regards,
Niels

michaelmaillot

Hi @nsoeth , I've submitted a fews changes to be done, let me know if you want any kind of help 🙂

Edit: as a guidance, I suggest you to run the solution locally: you'll be able to test the DynamicForm through the included ControlsTests webpart. Or you can test it on your consuming solution with npm link command. Feel free to reach out if you need assistance.

michaelmaillot · 2024-04-02T08:17:23Z

src/services/SPService.ts

@@ -221,7 +221,8 @@ export default class SPService implements ISPService {
    filterString?: string,
    substringSearch: boolean = false,
    orderBy?: string,
-    cacheInterval: number = 1): Promise<any[]> { // eslint-disable-line @typescript-eslint/no-explicit-any
+    cacheInterval: number = ICON_GENERIC_16,


I think that this should be:

cacheInterval: number = 1,

michaelmaillot · 2024-04-02T08:20:55Z

src/services/SPService.ts

@@ -259,7 +260,7 @@ export default class SPService implements ISPService {
        return filteredItems;
      }

-      apiUrl = `${webAbsoluteUrl}/_api/web/lists('${listId}')/items?$select=${keyInternalColumnName || 'Id'},${internalColumnName},FieldValuesAsText/${internalColumnName}&$expand=FieldValuesAsText&$orderby=${orderBy}${filterString ? '&$filter=' + filterString : ''}`;
+      apiUrl = `${webAbsoluteUrl}/_api/web/lists('${listId}')/items?$select=${keyInternalColumnName || 'Id'},${internalColumnName},FieldValuesAsText/${internalColumnName}&$expand=FieldValuesAsText&$orderby=${orderBy}${filterString ? '&$filter=' + filterString : ''}${top ? `&$top=${top}` : ''};


There's a missing backtick (`) at the end of this line, which raises errors on this file during the build.

The top prop shouldn't be placed here but here.

michaelmaillot · 2024-04-02T08:27:11Z

src/services/SPService.ts

-          return [{ key: result[fieldName].ID, name: result[fieldName][lookupFieldName || 'Title'] }];
+          let value = result[fieldName][lookupFieldName || 'Title'];
+          const dateVal = Date.parse(value);
+          if (dateVal !== NaN) {


You don't have to update this line because the getLookupValue is not used and should be deleted.

src/services/SPService.ts

michaelmaillot · 2024-04-02T08:27:34Z

src/services/SPService.ts

-             lookups.push({ key: singleItem.ID, name: singleItem[lookupFieldName || 'Title'] });
+             let value = singleItem[fieldName][lookupFieldName || 'Title'];
+              const dateVal = Date.parse(value);
+              if (dateVal !== NaN) {


It would be better to compare with the type function:

if (!Number.isNaN(dateVal))

michaelmaillot · 2024-04-02T12:33:57Z

src/services/SPService.ts

@@ -221,7 +221,8 @@ export default class SPService implements ISPService {
    filterString?: string,
    substringSearch: boolean = false,
    orderBy?: string,
-    cacheInterval: number = 1): Promise<any[]> { // eslint-disable-line @typescript-eslint/no-explicit-any
+    cacheInterval: number = ICON_GENERIC_16,
+    top?: number): Promise<any[]> { // eslint-disable-line @typescript-eslint/no-explicit-any


top property should be placed before cacheInterval as this one has a default value. Otherwise, there will be a confusion if itemitemsQueryCountLimit prop is filled.

michaelmaillot · 2024-04-12T14:02:08Z

src/services/SPService.ts

            });
           }
           //single select lookups are objects
           else {
             const singleItem = result[fieldName];
-             lookups.push({ key: singleItem.ID, name: singleItem[lookupFieldName || 'Title'] });
+             let value = singleItem[fieldName][lookupFieldName || 'Title'];


This should be singleItem[lookupFieldName || 'Title'] because you've already iterate into the fieldName data.

michaelmaillot · 2024-04-12T15:15:21Z

src/services/SPService.ts

-            result[fieldName].forEach(element => {
-              lookups.push({ key: element.ID, name: element[lookupFieldName || 'Title'] });
+            result[fieldName].forEach(element => {                
+              let value = element[fieldName][lookupFieldName || 'Title'];


This should be element[lookupFieldName || 'Title'] because you've already iterate into the fieldName data.

3.18.0 Release

michaelmaillot · 2024-05-29T05:59:50Z

Hi @nsoeth,

Are you still working on this one? Do you need any kind of help?

nsoeth · 2024-05-29T12:26:35Z

Hi @michaelmaillot
Sorry, lot of things to do the last few months but I updated the PR according to your review.

michaelmaillot · 2024-07-31T07:00:27Z

Merged manually, thank you!

nsoeth added 3 commits December 7, 2023 15:27

More than 100 lookup values

883ecbb

remove top5000 from getLookupValue

e91b04e

Format date in lookup fields

f531877

github-actions bot reviewed Dec 7, 2023

View reviewed changes

Niels Soeth and others added 2 commits February 27, 2024 14:30

add itemsQueryCountLimit property to ListItemPicker, DynamicField

627d132

Merge branch 'dev' into master

bfbf59d

michaelmaillot requested changes Apr 12, 2024

View reviewed changes

Merge pull request pnp#1816 from pnp/dev

0f857b9

3.18.0 Release

nsoeth and others added 2 commits May 29, 2024 14:04

Merge branch 'pnp:master' into master

c94de38

update NaN check, add $top, change param order

2ac28a2

nsoeth requested a review from michaelmaillot May 29, 2024 12:26

GuidoZam mentioned this pull request Jun 29, 2024

Dynamic Form - Lookup field limited to first 100 items #1827

Open

michaelmaillot merged commit 783568e into pnp:dev Jul 31, 2024
1 check passed

michaelmaillot added the status:fixed-next-drop Issue will be fixed in upcoming release. label Jul 31, 2024

michaelmaillot added this to the 3.19.0 milestone Jul 31, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix #1721 #1722

Fix #1721 #1722

nsoeth commented Dec 7, 2023

github-actions bot left a comment

michaelmaillot commented Feb 8, 2024

nsoeth commented Feb 27, 2024

michaelmaillot left a comment •

edited

Loading

michaelmaillot Apr 2, 2024

michaelmaillot Apr 2, 2024

michaelmaillot Apr 2, 2024

michaelmaillot Apr 2, 2024

michaelmaillot Apr 2, 2024

michaelmaillot Apr 12, 2024

michaelmaillot Apr 12, 2024

michaelmaillot commented May 29, 2024

nsoeth commented May 29, 2024

michaelmaillot commented Jul 31, 2024

Fix #1721 #1722

Fix #1721 #1722

Conversation

nsoeth commented Dec 7, 2023

What's in this Pull Request?

Guidance

github-actions bot left a comment

Choose a reason for hiding this comment

michaelmaillot commented Feb 8, 2024

nsoeth commented Feb 27, 2024

michaelmaillot left a comment • edited Loading

Choose a reason for hiding this comment

michaelmaillot Apr 2, 2024

Choose a reason for hiding this comment

michaelmaillot Apr 2, 2024

Choose a reason for hiding this comment

michaelmaillot Apr 2, 2024

Choose a reason for hiding this comment

michaelmaillot Apr 2, 2024

Choose a reason for hiding this comment

michaelmaillot Apr 2, 2024

Choose a reason for hiding this comment

michaelmaillot Apr 12, 2024

Choose a reason for hiding this comment

michaelmaillot Apr 12, 2024

Choose a reason for hiding this comment

michaelmaillot commented May 29, 2024

nsoeth commented May 29, 2024

michaelmaillot commented Jul 31, 2024

michaelmaillot left a comment •

edited

Loading