fix bug in readme display issue #1495 #1724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
Hi @ValerasNarbutas, Thanks for this PR! May I ask you which version of Material for MkDocs did you use during your tests? Because even if there's no doubt that we have to upgrade current supported version (3.1.0), I've tested your changes with this one and the display is still wrong. But if I remove tabs indent for the code blocks, it's working. Example with the Before
After
I thinkg that for now, the best fix would be to remove tabs in the code blocks. Then we'll update the version of Material for MkDocs. Are you ok with this? |
|
Yes, off course! Not sure about version:) had similar issue in my repo, now thinking maybe I need to recheck it with your solution. |
|
Thanks you @ValerasNarbutas! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this Pull Request?
Having sh incode does not compile in web version, changed to bash