Skip to content

Commit

Permalink
Fourth incremental upgrade to SPFx v1.16.1 (#1424)
Browse files Browse the repository at this point in the history
* First incremental upgrade to SPFx v1.11.0

* Second incremental upgrade from SPFx v1.11.0 to SPFx v1.13.0

* Third incremental upgrade from spfx v1.13.0 to spfx v1.15.0

* Fourth incremental upgrade to SPFx v1.16.1

* Updated .nvrmc file

* Delete samples/react-command-print/package-lock.json

* updated build with correct version of node

* Resolving comments from Adam wojcik

* Updated docs

* fixup

---------

Co-authored-by: Adam Wójcik <[email protected]>
  • Loading branch information
NishkalankBezawada and Adam-it authored Nov 7, 2024
1 parent d80d739 commit ba8e13f
Show file tree
Hide file tree
Showing 25 changed files with 23,037 additions and 192 deletions.
363 changes: 363 additions & 0 deletions samples/react-command-print/.eslintrc.js

Large diffs are not rendered by default.

3 changes: 3 additions & 0 deletions samples/react-command-print/.gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ lib
solution
temp
*.sppkg
.heft

# Coverage directory used by tools like istanbul
coverage
Expand All @@ -30,3 +31,5 @@ obj

# Styles Generated Code
*.scss.ts
# Release folder
release
16 changes: 16 additions & 0 deletions samples/react-command-print/.npmignore
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
!dist
config

gulpfile.js

release
src
temp

tsconfig.json


*.log

.yo-rc.json
.vscode
Binary file added samples/react-command-print/.nvmrc
Binary file not shown.
9 changes: 7 additions & 2 deletions samples/react-command-print/.yo-rc.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,17 @@
"@microsoft/generator-sharepoint": {
"isCreatingSolution": true,
"environment": "spo",
"version": "1.7.0",
"version": "1.16.1",
"libraryName": "react-command-print",
"libraryId": "138b7ab0-1bff-4801-894e-86b5cce48624",
"packageManager": "npm",
"isDomainIsolated": false,
"componentType": "extension",
"extensionType": "ListViewCommandSet"
"nodeVersion": "16.18.1",
"extensionType": "ListViewCommandSet",
"sdkVersions": {
"@microsoft/microsoft-graph-client": "3.0.2",
"@microsoft/teams-js": "2.4.1"
}
}
}
6 changes: 4 additions & 2 deletions samples/react-command-print/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@ This sample shows how you can print list items using different templates, site a

## Compatibility

![SPFx 1.7](https://img.shields.io/badge/version-1.7-green.svg)
![Node.js 8.x](https://img.shields.io/badge/Node.js-8.x-green.svg)
![SPFx 1.16.1](https://img.shields.io/badge/version-1.16.1-green.svg)
![Node.js 14.x](https://img.shields.io/badge/Node.js-14.x-green.svg)
![SharePoint Online](https://img.shields.io/badge/SharePoint-Online-yellow.svg)
![Workbench Hosted: Does not work with local workbench](https://img.shields.io/badge/Workbench-Hosted-yellow.svg "Does not work with local workbench")

Expand All @@ -24,13 +24,15 @@ Solution|Author(s)
--------|---------
react-command-print | Ramin Ahmadi
react-command-print | Ari Gunawan ([@arigunawan3023](https://twitter.com/arigunawan3023))
react-command-print | Nishkalank Bezawada ([@im_nishkalank](https://twitter.com/im_nishkalank))

## Version history

Version|Date|Comments
-------|----|--------
1.0|Dec 05, 2018|Initial release
1.1|May 02, 2021|Replace typestyle with mergeStyles (Ari Gunawan)
1.2|October 30, 2024|Upgraded to SPFx v1.16.1 (Nishkalank Bezawada)

## Minimal Path to Awesome

Expand Down
11 changes: 9 additions & 2 deletions samples/react-command-print/assets/sample.json
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
"This sample shows how you can print list items using different templates, site admin can add, edit or remove templates and users can print items based on those templates."
],
"creationDateTime": "2018-12-05",
"updateDateTime": "2018-12-05",
"updateDateTime": "2024-10-30",
"products": [
"SharePoint"
],
Expand All @@ -20,7 +20,7 @@
},
{
"key": "SPFX-VERSION",
"value": "1.7"
"value": "1.16.1"
}
],
"tags": [],
Expand All @@ -42,6 +42,13 @@
"pictureUrl": "https://github.com/AhmadiRamin.png",
"name": "Ramin Ahmadi",
"twitter": "raminahmadi1986"
},
{
"gitHubAccount": "NishkalankBezawada",
"company": "Bravero AB",
"pictureUrl": "https://github.com/NishkalankBezawada.png",
"name": "Nishkalank Bezawada",
"twitter": "im_nishkalank"
}
],
"references": [
Expand Down
4 changes: 0 additions & 4 deletions samples/react-command-print/config/copy-assets.json

This file was deleted.

Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"$schema": "https://developer.microsoft.com/json-schemas/spfx-build/deploy-azure-storage.schema.json",
"workingDir": "./temp/deploy/",
"workingDir": "./release/assets/",
"account": "<!-- STORAGE ACCOUNT NAME -->",
"container": "react-command-print",
"accessKey": "<!-- ACCESS KEY -->"
Expand Down
18 changes: 18 additions & 0 deletions samples/react-command-print/config/package-solution.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,24 @@
"version": "1.1.0.0",
"includeClientSideAssets": true,
"skipFeatureDeployment": false,
"developer": {
"name": "",
"privacyUrl": "",
"termsOfUseUrl": "",
"websiteUrl": "",
"mpnId": ""
},
"metadata": {
"shortDescription": {
"default": "react-command-print description"
},
"longDescription": {
"default": "react-command-print description"
},
"screenshotPaths": [],
"videoUrl": "",
"categories": []
},
"features": [
{
"title": "Application Extension - Deployment of custom action.",
Expand Down
3 changes: 3 additions & 0 deletions samples/react-command-print/config/sass.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
{
"$schema": "https://developer.microsoft.com/json-schemas/core-build/sass.schema.json"
}
2 changes: 1 addition & 1 deletion samples/react-command-print/config/serve.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"$schema": "https://developer.microsoft.com/json-schemas/core-build/serve.schema.json",
"$schema": "https://developer.microsoft.com/json-schemas/spfx-build/spfx-serve.schema.json",
"port": 4321,
"https": true,
"serveConfigurations": {
Expand Down
9 changes: 9 additions & 0 deletions samples/react-command-print/gulpfile.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,4 +4,13 @@ const gulp = require('gulp');
const build = require('@microsoft/sp-build-web');
build.addSuppression(`Warning - [sass] The local CSS class 'ms-Grid' is not camelCase and will not be type-safe.`);

var getTasks = build.rig.getTasks;
build.rig.getTasks = function () {
var result = getTasks.call(build.rig);

result.set('serve', result.get('serve-deprecated'));

return result;
};

build.initialize(gulp);
Loading

0 comments on commit ba8e13f

Please sign in to comment.