Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade react-application-breadcrumb to SPFx v1.20.0 #1419

Merged
merged 6 commits into from
Oct 28, 2024
Merged

Upgrade react-application-breadcrumb to SPFx v1.20.0 #1419

merged 6 commits into from
Oct 28, 2024

Conversation

tom-daly
Copy link
Contributor

@tom-daly tom-daly commented Oct 3, 2024

By submitting this pull request, you agree to the contribution guidelines

If you aren't familiar with how to contribute to open-source repositories using GitHub, or if you find the instructions on this page confusing, sign up for one of our Sharing is Caring events. It's completely free, and we'll guide you through the process.

Q A
Bug fix? no
New feature? no
New sample? no
Related issues? #1412

What's in this Pull Request?

  • Rebuild as SPFx v1.20.0
  • Remove Office UI Fabric replace with Fluent UI
  • fix critical typescript issues
  • validate functionality

@tom-daly tom-daly changed the title Upgrade react application breadcrumb Upgrade react application breadcrumb to SPFx v1.20.0 Oct 3, 2024
@tom-daly tom-daly changed the title Upgrade react application breadcrumb to SPFx v1.20.0 Upgrade react-application-breadcrumb to SPFx v1.20.0 Oct 3, 2024
@Adam-it Adam-it self-assigned this Oct 5, 2024
@Adam-it
Copy link
Member

Adam-it commented Oct 5, 2024

Thank you for opening a PR to our samples repo and helping us upgrade our project 👍
We will try to review this PR ASAP

Adam-it
Adam-it requested changes Oct 11, 2024
View reviewed changes
Copy link
Member

@Adam-it Adam-it left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tom-daly Awesome work so far 👏👏👏
I really like the changes and the refactor done along the way. You Rock 🤩
Unfortunately I noticed a small left over we need to sort out before we merge 👍. Please do give it a double check 🙏

samples/react-application-breadcrumb/src/extensions/siteBreadcrumb/loc/myStrings.d.ts Outdated Show resolved Hide resolved
@Adam-it Adam-it marked this pull request as draft October 11, 2024 18:54
@Adam-it
Copy link
Member

Adam-it commented Oct 22, 2024

@tom-daly are you still working on this PR? If it is ready to be merged please do let us know by hitting the Ready for review button 👍

@tom-daly tom-daly marked this pull request as ready for review October 23, 2024 01:05
@tom-daly tom-daly requested a review from Adam-it October 23, 2024 01:06
@tom-daly
Copy link
Contributor Author

@Adam-it yes it's been ready, thanks for checking up as I did not realize I needed to push that button. It's ready for review

@Adam-it Adam-it linked an issue Oct 28, 2024 that may be closed by this pull request
Upgrade Breadcrumb Application Customizer extension to latest version of SPFx - Refresh Rangers Hacktoberfest Event #1412
Closed
Adam-it
Adam-it approved these changes Oct 28, 2024
View reviewed changes
Copy link
Member

@Adam-it Adam-it left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work 👏👏👏👏
You Rock 🤩

@Adam-it Adam-it merged commit 73d6582 into pnp:main Oct 28, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Adam-it Adam-it Adam-it approved these changes

Assignees

@Adam-it Adam-it

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@tom-daly @Adam-it