feat: read from the local store if available

crates/package-manager/src/install_package_by_snapshot.rs

@@ -6,7 +6,7 @@
 use pacquet_tarball::{DownloadTarballToStore, TarballError};
 use pipe_trait::Pipe;
 use reqwest::Client;
-use std::borrow::Cow;
+use std::{borrow::Cow, ffi::OsString, io::ErrorKind};
 
 /// This subroutine downloads a package tarball, extracts it, installs it to a virtual dir,
 /// then creates the symlink layout for the package.
@@ -56,17 +56,34 @@
             }
         };
 
-        // TODO: skip when already exists in store?
-        let cas_paths = DownloadTarballToStore {
-            http_client,
-            store_dir: &config.store_dir,
-            package_integrity: integrity,
-            package_unpacked_size: None,
-            package_url: &tarball_url,
-        }
-        .run_without_mem_cache()
-        .await
-        .map_err(InstallPackageBySnapshotError::DownloadTarball)?;
+        let store_dir = &config.store_dir;
+        let cas_paths = match store_dir.read_index_file(integrity) {
+            Ok(index) => store_dir
+                .cas_file_paths_by_index(&index)
+                .map(|(entry_path, store_path)| (OsString::from(entry_path), store_path))
+                .collect(),
+            Err(error) => {
+                if error.io_error_kind() != Some(ErrorKind::NotFound) {
+                    let path = error.file_path();
+                    tracing::warn!(
+                        target: "pacquet::read_store",
+                        ?error,
+                        ?path,
+                        "Failed to read index from store",
+                    );
+                }
+                DownloadTarballToStore {
+                    http_client,
+                    store_dir,
+                    package_integrity: integrity,
+                    package_unpacked_size: None,
+                    package_url: &tarball_url,
+                }
+                .run_without_mem_cache()
+                .await
+                .map_err(InstallPackageBySnapshotError::DownloadTarball)?
+            }
+        };
 
         CreateVirtualDirBySnapshot {
             virtual_store_dir: &config.virtual_store_dir,

crates/store-dir/src/cas_file.rs

@@ -1,8 +1,9 @@
-use crate::{FileHash, StoreDir};
+use crate::{FileHash, PackageFilesIndex, StoreDir};
 use derive_more::{Display, Error};
 use miette::Diagnostic;
-use pacquet_fs::{ensure_file, file_mode::EXEC_MODE, EnsureFileError};
+use pacquet_fs::{ensure_file, file_mode, EnsureFileError};
 use sha2::{Digest, Sha512};
+use ssri::{Algorithm, Integrity};
 use std::path::PathBuf;
 
 impl StoreDir {
@@ -12,6 +13,28 @@
         let suffix = if executable { "-exec" } else { "" };
         self.file_path_by_hex_str(&hex, suffix)
     }
+
+    /// List maps from index entry to real or would-be file path in the store directory.
+    pub fn cas_file_paths_by_index<'a>(
+        &'a self,
+        index: &'a PackageFilesIndex,
+    ) -> impl Iterator<Item = (&'a str, PathBuf)> + 'a {
+        index.files.iter().map(|(entry_path, info)| {
+            let entry_path = entry_path.as_str();
+            let (algorithm, hex) = info
+                .integrity
+                .parse::<Integrity>()
+                .expect("parse integrity") // TODO: parse integrity before this
+                .to_hex();
+            assert!(
+                matches!(algorithm, Algorithm::Sha512 | Algorithm::Sha1),
+                "Only Sha1 and Sha512 are supported. {algorithm} isn't",
+            ); // TODO: write a custom parser and remove this
+            let suffix = if file_mode::is_all_exec(info.mode) { "-exec" } else { "" };
+            let cas_path = self.file_path_by_hex_str(&hex, suffix);
+            (entry_path, cas_path)
+        })
+    }
 }
 
 /// Error type of [`StoreDir::write_cas_file`].
@@ -29,7 +52,7 @@
     ) -> Result<(PathBuf, FileHash), WriteCasFileError> {
         let file_hash = Sha512::digest(buffer);
         let file_path = self.cas_file_path(file_hash, executable);
-        let mode = executable.then_some(EXEC_MODE);
+        let mode = executable.then_some(file_mode::EXEC_MODE);
         ensure_file(&file_path, buffer, mode).map_err(WriteCasFileError::WriteFile)?;
         Ok((file_path, file_hash))
     }

crates/store-dir/src/index_file.rs

@@ -4,7 +4,12 @@
 use pacquet_fs::{ensure_file, EnsureFileError};
 use serde::{Deserialize, Serialize};
 use ssri::{Algorithm, Integrity};
-use std::{collections::HashMap, path::PathBuf};
+use std::{
+    collections::HashMap,
+    fs::File,
+    io::{self, ErrorKind},
+    path::{Path, PathBuf},
+};
 
 impl StoreDir {
     /// Path to an index file of a tarball.
@@ -39,22 +44,73 @@
 
 /// Error type of [`StoreDir::write_index_file`].
 #[derive(Debug, Display, Error, Diagnostic)]
-pub enum WriteTarballIndexFileError {
+pub enum WriteIndexFileError {
     WriteFile(EnsureFileError),
 }
 
 impl StoreDir {
     /// Write a JSON file that indexes files in a tarball to the store directory.
     pub fn write_index_file(
         &self,
-        tarball_integrity: &Integrity,
+        integrity: &Integrity,
         index_content: &PackageFilesIndex,
-    ) -> Result<(), WriteTarballIndexFileError> {
-        let file_path = self.index_file_path(tarball_integrity);
+    ) -> Result<(), WriteIndexFileError> {
+        let file_path = self.index_file_path(integrity);
         let index_content =
             serde_json::to_string(&index_content).expect("convert a TarballIndex to JSON");
         ensure_file(&file_path, index_content.as_bytes(), Some(0o666))
-            .map_err(WriteTarballIndexFileError::WriteFile)
+            .map_err(WriteIndexFileError::WriteFile)
+    }
+}
+
+/// Error type of [`StoreDir::read_index_file`].
+#[derive(Debug, Display, Error, Diagnostic)]
+pub enum ReadIndexFileError {
+    #[display("Failed to open {file_path:?}: {error}")]
+    OpenFile {
+        file_path: PathBuf,
+        #[error(source)]
+        error: io::Error,
+    },
+    #[display("Failed to parse content of {file_path:?}: {error}")]
+    ParseFile {
+        file_path: PathBuf,
+        #[error(source)]
+        error: serde_json::Error,
+    },
+}
+
+impl StoreDir {
+    /// Read an index file from the store directory.
+    pub fn read_index_file(
+        &self,
+        integrity: &Integrity,
+    ) -> Result<PackageFilesIndex, ReadIndexFileError> {
+        let file_path = self.index_file_path(integrity);
+        let file = match File::open(&file_path) {
+            Ok(file) => file,
+            Err(error) => return Err(ReadIndexFileError::OpenFile { file_path, error }),
+        };
+        match serde_json::from_reader(file) {
+            Ok(content) => Ok(content),
+            Err(error) => Err(ReadIndexFileError::ParseFile { file_path, error }),
+        }
+    }
+}
+
+impl ReadIndexFileError {
+    pub fn file_path(&self) -> &Path {
+        match self {
+            ReadIndexFileError::OpenFile { file_path, .. } => file_path,
+            ReadIndexFileError::ParseFile { file_path, .. } => file_path,
+        }
+    }
+
+    pub fn io_error_kind(&self) -> Option<ErrorKind> {
+        match self {
+            ReadIndexFileError::OpenFile { error, .. } => Some(error.kind()),
+            ReadIndexFileError::ParseFile { error, .. } => error.io_error_kind(),
+        }
     }
 }
 
@@ -66,9 +122,9 @@
     #[test]
     fn index_file_path() {
         let store_dir = StoreDir::new("STORE_DIR");
-        let tarball_integrity =
+        let integrity =
             IntegrityOpts::new().algorithm(Algorithm::Sha512).chain(b"TARBALL CONTENT").result();
-        let received = store_dir.index_file_path(&tarball_integrity);
+        let received = store_dir.index_file_path(&integrity);
         let expected = "STORE_DIR/v3/files/bc/d60799116ebef60071b9f2c7dafd7e2a4e1b366e341f750b2de52dd6995ab409b530f31b2b0a56c168a808a977156c3f5f13b026fb117d36314d8077f8733f-index.json";
         let expected: PathBuf = expected.split('/').collect();
         assert_eq!(&received, &expected);

crates/tarball/src/lib.rs

@@ -13,7 +13,7 @@ use derive_more::{Display, Error, From};
 use miette::Diagnostic;
 use pacquet_fs::file_mode;
 use pacquet_store_dir::{
-    PackageFileInfo, PackageFilesIndex, StoreDir, WriteCasFileError, WriteTarballIndexFileError,
+    PackageFileInfo, PackageFilesIndex, StoreDir, WriteCasFileError, WriteIndexFileError,
 };
 use pipe_trait::Pipe;
 use reqwest::Client;
@@ -69,7 +69,7 @@ pub enum TarballError {
     #[from(ignore)]
     #[display("Failed to write tarball index: {_0}")]
     #[diagnostic(transparent)]
-    WriteTarballIndexFile(WriteTarballIndexFileError),
+    WriteTarballIndexFile(WriteIndexFileError),
 
     #[from(ignore)]
     #[diagnostic(code(pacquet_tarball::task_join_error))]