Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(cli): --save-dev with --save-prod implies as dev #216

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

await-ovo
Copy link
Member

Behavior consistent with pnpm when --save-dev with --save-prod:

pnpm add some-pkg --save-prod --save-dev will only be installed as devDependencies.

Copy link

codecov bot commented Nov 23, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c62a631) 92.65% compared to head (75315ef) 92.64%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #216      +/-   ##
==========================================
- Coverage   92.65%   92.64%   -0.02%     
==========================================
  Files          57       57              
  Lines        2847     2856       +9     
==========================================
+ Hits         2638     2646       +8     
- Misses        209      210       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@KSXGitHub
Copy link
Contributor

I think pnpm is in the wrong in this case, but no one cares enough to fix it yet.

What's your opinion, @zkochan?

@zkochan
Copy link
Member

zkochan commented Nov 28, 2023

How would you expect it to work at all? I would throw an error in this case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants