Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove posttest #28

Merged
merged 1 commit into from
May 11, 2024
Merged

chore: remove posttest #28

merged 1 commit into from
May 11, 2024

Conversation

KSXGitHub
Copy link

eslint suddenly fails, so it needs to be removed for the time being

@KSXGitHub KSXGitHub requested a review from zkochan May 11, 2024 11:21
@zkochan
Copy link
Member

zkochan commented May 11, 2024

Why? It doesn't fail on main branch.

@KSXGitHub
Copy link
Author

pnpm test fails on my terminal (main branch, up-to-date):

terminal screenshot

@KSXGitHub
Copy link
Author

The CI fails here: #29 (it fails when new PR targeting main branch is created)

@zkochan
Copy link
Member

zkochan commented May 11, 2024

Don't remove eslint. Just remove the posttest script.

@KSXGitHub KSXGitHub changed the title chore: remove eslint chore: remove posttest May 11, 2024
@KSXGitHub
Copy link
Author

Don't remove eslint. Just remove the posttest script.

done

@zkochan zkochan merged commit 6e544aa into main May 11, 2024
12 checks passed
@KSXGitHub KSXGitHub deleted the delete-eslint branch May 11, 2024 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants