Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions .github/dependabot.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,9 @@ updates:
directory: /
schedule:
interval: daily
timezone: Asia/Tokyo
cooldown:
default-days: 1
allow:
- dependency-type: all
rebase-strategy: auto
Expand All @@ -15,16 +18,23 @@ updates:
- '*'

- package-ecosystem: npm
directory: '/'
directories:
- '/package/'
- '/tests/'
schedule:
interval: daily
timezone: Asia/Tokyo
cooldown:
default-days: 1
exclude:
- 'pnpm'
- 'appstore-connect-jwt-generator-core'
allow:
- dependency-type: all
rebase-strategy: auto
assignees:
- poad
groups:
esm:
npm:
patterns:
- '*'
2 changes: 1 addition & 1 deletion .github/workflows/auto-merge.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ permissions:

jobs:
auto-merge:
if: github.event.pull_request.draft == false
if: ${{ !github.event.pull_request.draft }}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GitHub Actionsの条件式を${{ }}で囲むのは良い改善です。これにより式の評価がより明確になり、予期しない文字列比較を避けることができます。


runs-on: ubuntu-latest
steps:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ jobs:
with:
node-version: ${{ matrix.node-version }}
check-latest: true
package-manager-cache: pnpm
package-manager-cache: false

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

package-manager-cache: falseに変更した理由が不明です。キャッシュを無効にすることでビルド時間が長くなる可能性があります。この変更が意図的なものか確認が必要です。


- uses: pnpm/action-setup@v4
name: Install pnpm
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/create-release-pr.yml
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ jobs:
with:
node-version: 'lts/*'
check-latest: true
package-manager-cache: pnpm
package-manager-cache: false

- uses: pnpm/action-setup@a7487c7e89a18df4991f7f222e4898a00d66ddda # v4.1.0
with:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ on:
jobs:
release:
if: |
(github.event.pull_request.merged == true && contains(github.event.pull_request.labels.*.name, 'Type: Release')) || github.event_name == 'workflow_dispatch'
${{ (github.event.pull_request.merged == true && contains(github.event.pull_request.labels.*.name, 'Type: Release')) || github.event_name == 'workflow_dispatch' }}
permissions:
contents: write
id-token: write # OIDC
Expand Down
Empty file modified bin/cli.js
100755 → 100644
Empty file.
49 changes: 30 additions & 19 deletions eslint.config.js → eslint.config.ts
Original file line number Diff line number Diff line change
@@ -1,55 +1,64 @@
// @ts-check

import { defineConfig } from 'eslint/config';
import eslint from '@eslint/js';
import { configs, parser } from 'typescript-eslint';
import stylistic from '@stylistic/eslint-plugin';
import tseslint from 'typescript-eslint';
import importPlugin from 'eslint-plugin-import';
import pluginPromise from 'eslint-plugin-promise'
// @ts-expect-error ignore type errors
import pluginPromise from 'eslint-plugin-promise';

import { includeIgnoreFile } from '@eslint/compat';
import path from "node:path";
import { fileURLToPath } from "node:url";
import path from 'node:path';
import { fileURLToPath } from 'node:url';

const __filename = fileURLToPath(import.meta.url);
const __dirname = path.dirname(__filename);
const gitignorePath = path.resolve(__dirname, ".gitignore");
const gitignorePath = path.resolve(__dirname, '.gitignore');

export default tseslint.config(
const eslintConfig = defineConfig(
{
ignores: [
...(includeIgnoreFile(gitignorePath).ignores ?? []),
...(includeIgnoreFile(gitignorePath).ignores || []),
'**/*.d.ts',
'*.js',
'src/tsconfig.json',
'src/stories',
'**/*.css',
'node_modules/**/*',
'out',
'cdk.out',
'dist',
'bin',
],
},
eslint.configs.recommended,
...tseslint.configs.strict,
...tseslint.configs.stylistic,
configs.strict,
configs.stylistic,
pluginPromise.configs['flat/recommended'],
{
files: ['src/**/*.ts'],
files: ['**/*.ts', '*.js'],
plugins: {
'@stylistic': stylistic,
},
languageOptions: {
parser: tseslint.parser,
ecmaVersion: 'latest',
sourceType: 'module',
parser,
parserOptions: {
tsconfigRootDir: __dirname,
project: './tsconfig-eslint.json',
},
},
extends: [
importPlugin.flatConfigs.recommended,
importPlugin.flatConfigs.typescript,
],
settings: {
'import/resolver': {
typescript: true,
node: true,
// You will also need to install and configure the TypeScript resolver
// See also https://github.com/import-js/eslint-import-resolver-typescript#configuration
'typescript': true,
'node': true,
},
},
plugins: {
'@stylistic': stylistic,
},
rules: {
'@stylistic/semi': ['error', 'always'],
'@stylistic/indent': ['error', 2],
Expand All @@ -59,3 +68,5 @@ export default tseslint.config(
},
},
);

export default eslintConfig;
Loading
Loading