Added type for clearing temporary values. #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DrPeterVanNostrand
force-pushed
the
add-sectemp-type
branch
from
869bdd6
to
fefb616
Compare
vkomenda
reviewed
Sep 11, 2018
src/poly.rs
Outdated
| @@ -42,8 +42,8 @@ pub struct Poly { | |||
| /// | |||
| /// # Panics | |||
| /// | |||
| /// Panics if we have hit the system's locked memory limit when `mlock`ing the new instance of | |||
| /// `Poly`. | |||
| /// Panics if we have reach the system's locked memory limit when locking the polynomial's | |||
src/secret.rs
Outdated
| @@ -0,0 +1,187 @@ | |||
| //! Utilities for working with secret values. This module includes functionality for locking (and | |||
| //! unlocking) memory into RAM, overwriting memory with zeros | |||
There was a problem hiding this comment.
The trailing period is missing.
src/secret.rs
Outdated
| /// # Errors | ||
| /// | ||
| /// An `Error::MlockFailed` is returned if we reach the system's locked memory limit or if we | ||
| /// attemt to lock an invalid region of memory. |
src/secret.rs
Outdated
| } | ||
| } | ||
|
|
||
| /// Unlocks the memory-lock for a region of memory marked as secret. If the secret region of |
There was a problem hiding this comment.
"memory lock" doesn't need a dash.
DrPeterVanNostrand
force-pushed
the
add-sectemp-type
branch
from
fefb616
to
7149a84
Compare
c0gent
reviewed
Sep 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
secretmodule.Safe<T>for clearing, locking, and unlocking temporary values that should be kept secret.Poly::extend_mlock(&mut self)andPoly::truncate_ mlock(&mut self)(locking on instantiation and destruction ofPolyis enough).Closes issue #24