Check database migrations before generating types for models #342
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So far, our testcases build RBS signatures from scratch every time. It is slow and unnecessary. This introduces a mechanism to share the built signatures across tests. Before: ``` Finished in 99.189478s, 0.2016 runs/s, 0.1815 assertions/s. 20 runs, 18 assertions, 0 failures, 0 errors, 0 skips ``` After: ``` Finished in 25.321047s, 0.7899 runs/s, 0.7109 assertions/s. 20 runs, 18 assertions, 0 failures, 0 errors, 0 skips ```
To ensure consistency between the database schema and the generated types, this adds a new feature that rbs_rails stops to generate types for models if the database is not migrated to the latest version. This feature can be configured via `check_db_migrations` settings. Thanks to @sinsoku Example: ``` $ bundle exec rbs_rails models Error: Migrations are pending. To resolve this issue, run: bin/rails db:migrate You have 1 pending migration: db/migrate/20250812173612_add_email_to_users.rb ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To ensure consistency between the database schema and the generated
types, this adds a new feature that rbs_rails stops to generate types
for models if the database is not migrated to the latest version.
This feature can be configured via
check_db_migrationssettings.Thanks to @sinsoku
Example:
Note: this contains #337.