Integrate model_dependencies.rbs to each model signatures #345
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So far, our testcases build RBS signatures from scratch every time. It is slow and unnecessary. This introduces a mechanism to share the built signatures across tests. Before: ``` Finished in 99.189478s, 0.2016 runs/s, 0.1815 assertions/s. 20 runs, 18 assertions, 0 failures, 0 errors, 0 skips ``` After: ``` Finished in 25.321047s, 0.7899 runs/s, 0.7109 assertions/s. 20 runs, 18 assertions, 0 failures, 0 errors, 0 skips ```
ActiveRecord::* and ActiveStorage::* are parts of Ruby on Rails, and their types are distributed on the gem_rbs_collection repo. Therefore, there is no reason to generate types for them.
As a preparation for LSP server, this integrates model_dependencies.rbs to each model signatures. With this change, the signature of dependencies will be separated to the each RBS file of the model. It allows to rbs_rails to generate signatures for models one by one, not only the whole of application. It also helps the LSP server generate signatures on the fly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a preparation for LSP server, this integrates model_dependencies.rbs
to each model signatures.
With this change, the signature of dependencies will be separated to the
each RBS file of the model. It allows to rbs_rails to generate
signatures for models one by one, not only the whole of application. It
also helps the LSP server generate signatures on the fly.
Note: this contains #344 and #337.