-
Notifications
You must be signed in to change notification settings - Fork 260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement cl_khr_icd 2.0.0 loader managed dispatch #1354
Conversation
8ab68a6
to
f5cd327
Compare
Thanks Brice! I'll launch the CIs. I added some questions in the extension PR. @franz can you add an ICD2-compliant ICD loader to one of the CIs? |
I can add it as soon as it lands in ocl-icd's ubuntu ppa. |
Thanks for the reviews. Not sure when this will be ready. I want to make sure I can implement instance layers on top of this (WIP is here https://github.com/Kerilk/pocl/tree/instance). |
@Kerilk it does not cleanup everything, but it does have cleanup - some drivers implement the cleanup hooks, and also there is code to unload LLVM (as much as possible). It's disabled by default, IIRC there were some problems with reliability, and there wasn't any official API to unload the drivers / platforms, only the compiler. However if you try |
There was some changes planned still to the icd2 in the OpenCL WG so let's revert this one. @franz can you do it in your next PR (my local PoCL repo is unclean)? |
This implements the loader managed dispatch strategy presented here: KhronosGroup/OpenCL-Docs#1003