WIP: make episode a required attribute for nodes

lib/radiator/outline/node.ex

@@ -22,14 +22,14 @@ defmodule Radiator.Outline.Node do
   end
 
   @required_fields [
-    :content
+    :content,
+    :episode_id
   ]
 
   @optional_fields [
     :creator_id,
     :parent_id,
-    :prev_id,
-    :episode_id # FIXME: should be required
+    :prev_id
   ]
 
   @all_fields @optional_fields ++ @required_fields

lib/radiator/podcast/episode.ex

@@ -1,7 +1,7 @@
 defmodule Radiator.Podcast.Episode do
   @moduledoc """
     Represents the Episode model.
-    TODO: Episodes should be numbered and ordered inside a show.
+    Episodes are numbered inside a show.
   """
   use Ecto.Schema
   import Ecto.Changeset

lib/radiator_web/controllers/api/outline_controller.ex

@@ -9,9 +9,6 @@ defmodule RadiatorWeb.Api.OutlineController do
       token
       |> decode_token()
       |> get_user_by_token()
-      # show will be send in request from frontend (show_id)
-      # fetch wanted/current episode for show
-
       |> create_node(content)
       |> get_response()
 

test/radiator/outline_test.exs

@@ -7,6 +7,7 @@ defmodule Radiator.OutlineTest do
     alias Radiator.Outline.Node
 
     import Radiator.OutlineFixtures
+    alias Radiator.PodcastFixtures
 
     @invalid_attrs %{content: nil}
 
@@ -21,22 +22,25 @@ defmodule Radiator.OutlineTest do
     end
 
     test "create_node/1 with valid data creates a node" do
-      valid_attrs = %{content: "some content"}
+      episode = PodcastFixtures.episode_fixture()
+      valid_attrs = %{content: "some content", episode_id: episode.id}
 
       assert {:ok, %Node{} = node} = Outline.create_node(valid_attrs)
       assert node.content == "some content"
     end
 
     test "create_node/1 trims whitespace from content" do
-      valid_attrs = %{content: "  some content  "}
+      episode = PodcastFixtures.episode_fixture()
+      valid_attrs = %{content: "  some content  ", episode_id: episode.id}
 
       assert {:ok, %Node{} = node} = Outline.create_node(valid_attrs)
       assert node.content == "some content"
     end
 
     test "create_node/1 can have a creator" do
+      episode = PodcastFixtures.episode_fixture()
       user = %{id: 2}
-      valid_attrs = %{content: "some content"}
+      valid_attrs = %{content: "some content", episode_id: episode.id}
 
       assert {:ok, %Node{} = node} = Outline.create_node(valid_attrs, user)
       assert node.content == "some content"

test/support/fixtures/outline_fixtures.ex

@@ -4,6 +4,7 @@ defmodule Radiator.OutlineFixtures do
   entities via the `Radiator.Outline` context.
   """
   alias Radiator.PodcastFixtures
+
   @doc """
   Generate a node.
   """
@@ -17,6 +18,7 @@ defmodule Radiator.OutlineFixtures do
         episode_id: episode.id
       })
       |> Radiator.Outline.create_node()
+
     node
   end
 end