Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove not needed view files #511

Closed
wants to merge 1 commit into from
Closed

Conversation

electronicbites
Copy link
Collaborator

@electronicbites electronicbites commented Dec 19, 2023

@sorax seems like removing the views wont work . they are referenced ....

@electronicbites electronicbites self-assigned this Dec 19, 2023
@sorax
Copy link
Collaborator

sorax commented Dec 19, 2023

the "view" files aren't in the current main branch. so everything fine so far, I would say.
can we close this?

@electronicbites
Copy link
Collaborator Author

electronicbites commented Dec 19, 2023

yes of course. perhaps this was also a misunderstanding. I tried to move the existing view files into its own folder. But then we discussed wether we need them at all. So currently these view files are in the controllers folder, like error and page html.
anyway this was just an experiment becaue we discussed that, I will close this PR to not confuse us any further ;)

@electronicbites electronicbites deleted the remove-view-templates branch December 21, 2023 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants