Skip to content

Fix OpenURL crash on macOS Sequoia #305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Fix OpenURL crash on macOS Sequoia #305

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ae60a5c
Fix OpenURL crash on macOS Sequoia
beetee17 Nov 12, 2024
cd9f717
Merge branch 'pointfreeco:main' into main
beetee17 Jan 13, 2025
7e6f809
Amended: Fix OpenURL crash on macOS Sequoia
beetee17 Jan 13, 2025
b58d7da
Remove unnecessary assertion
beetee17 Jan 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Sources/Dependencies/DependencyValues/OpenURL.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@

@available(iOS 14, macOS 11, tvOS 14, watchOS 7, *)
private enum OpenURLKey: DependencyKey {
static let liveValue = OpenURLEffect { url in
static let liveValue = OpenURLEffect { @MainActor url in
Copy link
Member

@stephencelis stephencelis Dec 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
static let liveValue = OpenURLEffect { @MainActor url in
// NB: This must be annotated '@MainActor' to avoid a Swift bug:
// https://github.com/pointfreeco/swift-dependencies/discussions/301
static let liveValue = OpenURLEffect { @MainActor url in

let stream = AsyncStream<Bool> { continuation in
let task = Task { @MainActor in
#if os(watchOS)
Expand Down